Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: floating labels do not work when type attribute is absent from input element #288 #289

Merged
merged 2 commits into from
Oct 10, 2022
Merged

fix: floating labels do not work when type attribute is absent from input element #288 #289

merged 2 commits into from
Oct 10, 2022

Conversation

coffeeandwork
Copy link

@coffeeandwork coffeeandwork commented Oct 9, 2022 •
edited
Loading

Proposed changes

Ensure that floating labels work correctly on input elements without an explicit type attribute.

Screenshots (if appropriate) or codepen:

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coffeeandwork coffeeandwork changed the title fix: floating labels do not work when type attribute is absent from input element #228 fix: floating labels do not work when type attribute is absent from input element #288 Oct 9, 2022
@Smankusors
Copy link
Member

LGTM
btw @DyegoCosta, I asked you to review this since you recently edit this one. Do you think it's ok? Not breaking yours? 😅

DyegoCosta
DyegoCosta suggested changes Oct 9, 2022
View reviewed changes
Copy link

@DyegoCosta DyegoCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You can also add a fixture in tests/spec/forms/formsFixture.html to cover this new field.

@coffeeandwork
Copy link
Author

LGTM

You can also add a fixture in tests/spec/forms/formsFixture.html to cover this new field.

Done.

@Smankusors Smankusors merged commit e5f5ebb into materializecss:main Oct 10, 2022
@Smankusors
Copy link
Member

Thanks for helping me review this one @DyegoCosta 😃

Btw, I also invited you @coffeeandwork as the member of materializecss, welcome! 🎉

@Smankusors Smankusors mentioned this pull request Oct 10, 2022
Closed
@coffeeandwork
Copy link
Author

Thanks for helping me review this one @DyegoCosta 😃

Btw, I also invited you @coffeeandwork as the member of materializecss, welcome! 🎉

Thank you all.

@Smankusors Smankusors added the bug Something isn't working label Oct 11, 2022
@Smankusors Smankusors added the hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smankusors Smankusors Smankusors approved these changes

@DyegoCosta DyegoCosta DyegoCosta approved these changes

Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest-accepted The PR is a valuable contribution that counts for the Hacktoberfest Event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coffeeandwork @Smankusors @DyegoCosta