Release 1.2.1

[wuda-io]

Proposed changes

Releasing 1.2.1 Mainly because fixing the husky issue during installation #313

Screenshots (if appropriate) or codepen:

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

• I have read the CONTRIBUTING document.
• My commit messages follows the conventional commit format
• My change requires a change to the documentation, and updated it accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[DanielRuf]

I have assigned @materializecss/members-write-access as reviewer since no one was informed due to the missing assignment.

[DanielRuf]

Hm, how can it happen that now we are missing some old entries?

[Smankusors]

oh, I forgot to mention this... the CHANGELOG needs a little manual fixes 😅

this one is missing because it could not find the commit on the main branch

I'm not sure how this happen though, but this PR changes has been bought by 55e4854 now

[Smankusors]

anyway, to reduce the manual work for CHANGELOG, how about if we include only from 1.2.0 to 1.2.1?

for the earlier versions, the user can read on releases page

wdyt?

[wuda-io]

anyway, to reduce the manual work for CHANGELOG, how about if we include only from 1.2.0 to 1.2.1?

for the earlier versions, the user can read on releases page

wdyt?

Yes thats better 👍, it should list only the differences/changes between 2 releases. Generating the whole log each time and overwrite it every release is not very efficient.

[wuda-io]

I have assigned @materializecss/members-write-access as reviewer since no one was informed due to the missing assignment.

Oh thats correct I forgot that, thanks!

[DanielRuf]

Oh thats correct I forgot that, thanks!

Regarding assignments, I will check if we can enable some sort of auto-assignments. So no PR will be missed then in the future.

[wuda-io]

Ok, please review, I have updated the changelog with only the differences since the last version (1.2.0)

[DanielRuf]

Ok, please review, I have updated the changelog with only the differences since the last version (1.2.0)

Seems now all the old changelog entries are gone.

[wuda-io]

Seems now all the old changelog entries are gone.

Yes, there was an error when generating the whole changelog, some PRs were not found and needed manual fixing.
@Smankusors suggested to only list the changes between two releases. (from 1.2.0 to 1.2.1) I also think this is the better approach. When looking up older changes this can be done via the release-page. Wdyt?

[Smankusors]

ooh! I just realized that we can use --base CHANGELOG.md to append the changelog, then there is no manual work anymore 😳

hmm but I'm still not sure if we should maintain a full changelog? I'm curious since we have a releases page, what's the purpose of the CHANGELOG.md anymore other than for drafting the release? 😅

[DanielRuf]

Changelog via GH interface and releases sounds way easier and better. Afaik GH supports the creation of the release changelog via click.

If this is the best option for us, then we can empty changelog.md and link there to https://github.com/materializecss/materialize/releases/tag/1.2.1 in there.

[Smankusors]

[wuda-io]

Changelog via GH interface and releases sounds way easier and better. Afaik GH supports the creation of the release changelog via click.

If this is the best option for us, then we can empty changelog.md and link there to https://github.com/materializecss/materialize/releases/tag/1.2.1 in there.

I will merge this now. We also can further improve the changelog handling, let us discuss ideas and improvements in a speperate issue. Thanks and happy holidays to all of you!