Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ts #335

Merged
merged 7 commits into from
Mar 13, 2023
Merged

Move to ts #335

merged 7 commits into from
Mar 13, 2023

Conversation

danice
Copy link

@danice danice commented Feb 22, 2023

Proposed changes

The objectives of this first step was:

  • just convert all files to typescript maintaining everything as is and with minimal changes in the code so it can be quickly revie (this means I have not dedicated to try add all type definitions, just the ones automatically added and some required ones.)
  • update the grunt process to use webpack instead of babel, but again maintaining everything as simple as possible.

Pending tasks

  1. Tests: There are about 3-4 test that I cannot get to work. I think I have been able to fix the tested functionality, but not in the test. As I have not been able to debug the tests is difficult for me to found the reason.
  2. Complete types for components. Add types for every component option.
  3. Someone who knows better the framework should check that grunt processes work completely as expected and a complete checking that components can we loaded and works just as before.

@wuda-io wuda-io merged commit 448662b into materializecss:v2-dev Mar 13, 2023
@wuda-io
Copy link
Member

wuda-io commented Mar 13, 2023

Oh I somehow could not add any merge commits here because your v2-dev branch was deleted 😄
I hope I get the missing tests to work!
Thanks for contributing, I will invite you as a member.

@danice
Copy link
Author

danice commented Mar 13, 2023

Great! Please tell me if you have any doubt with the PR or if can help with some task...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants