fix: library does not load in webpack projects #364 #365
Conversation
There was a problem hiding this comment.
I looked it up on the webpack docu, but I did not fully understand why you changed this. Can you elaborate what this does?
There was a problem hiding this comment.
Ah, is it because of the Type any at the import?
There was a problem hiding this comment.
The previous
module.exports = M
is the export following CommonJS format. After different proofs I was not able to make it work in the example ts-webpack project.
So I decided to change the format to the ES Module syntax (that of course is what is used now in typescript projects). With this it worked perfectly in the webpack project and I had to do the other changes in the webpack output config to make it work in plain js projects.
The
optimization: {
minimize: false,
}
was only to debug the result code more easily but I think we can removed it now.
| optimization: { | ||
| minimize: false, | ||
| } |
There was a problem hiding this comment.
Why is that? I guess because of the function name obfuscation due to minimization process.
|
Thanks for your contribution! Please next time please base your PR into the DEV branch, |
Proposed changes
Changed library export method to
export default M;and the configuration of webpack output library to the options that has proved to work without breaking changes for existing doc pages and also for projects using the library in typescript classes and webpack for bundling.Types of changes
Checklist:
this can be tested with the webpack version of document that was linked in the issue description.
It would be good to have some official demo of the library in a webpack project
[x ] I have read the CONTRIBUTING document.
[x ] My commit messages follows the conventional commit format
My change requires a change to the documentation, and updated it accordingly.
I have added tests to cover my changes.
All new and existing tests passed.