Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for text input suffix icons #59

Merged
merged 1 commit into from
Dec 30, 2020
Merged

add support for text input suffix icons #59

merged 1 commit into from
Dec 30, 2020

Conversation

nicknickel
Copy link

Proposed changes

  • Implements Add input suffix Dogfalo/materialize#2490 to have text input suffix icons.
    • That PR was issued under what appears to be an older version of the code so there isn't much that is similar between this PR and that one.

Screenshots (if appropriate) or codepen:

Screen Shot 2020-12-29 at 8 31 48 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nicknickel nicknickel requested a review from a team December 30, 2020 02:57
@DanielRuf DanielRuf added component: forms enhancement New feature or request labels Dec 30, 2020
Copy link

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Smankusors Smankusors merged commit e6f4c23 into materializecss:v1-dev Dec 30, 2020
@nicknickel nicknickel deleted the add-input-suffix branch December 30, 2020 20:16
@lelabo-m
Copy link

In this PR, only changes to styles have been made.
Tell me if I am wrong, but from what I observed, form.js should be updated to have the same behavior between prefix and suffix icons.
I am thinking about adding the active class to icons depending on the events happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: forms enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants