Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6279: fixed aligning of dropdown with coverTrigger=false, when can align bottom #87

Merged

Conversation

bugy
Copy link

@bugy bugy commented Mar 23, 2021

This is another PR for Dogfalo#6279. The initial one is #4.

Proposed changes

Original PR #4 fixes the alignment issue when there is not enough space both on the bottom and top sides.
This PR fixes the dropdown cover when there is not enough space at the bottom side, but still enough space at the top side (so scrolling is not needed).

Screenshots (if appropriate) or codepen:

(top and bottow browser panels are part of screenshot, to demonstrate which size is available)
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors
Copy link
Member

hmm wait I having difficulty to reproduce this bug btw. I tried with the updated doc website in https://materializecss.github.io/materialize/autocomplete.html, and it doesn't seems to cover the text field.

The screenshot you given, is that from materializecss.com or materializecss.github.io?

@bugy
Copy link
Author

bugy commented Apr 22, 2021

Hi @Smankusors I reproduced it locally. But it's the same on the doc website:
image

Please note, that there should be enough space for the full dropdown at the top

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only an additional Condition. Tried to Reproduce the issue in the current version as displayed in the Screenshot and it also covers the Input-Field.

Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, for some reason, I can reproduce it now 😵

LGTM, thanks for the PR 👍

@Smankusors Smankusors merged commit 87f45d6 into materializecss:v1-dev Apr 22, 2021
@DanielRuf
Copy link

Hi @bugy,

thanks for your contribution. You should have received an invitation for @materializecss as part of the members group a few moments ago.

@bugy
Copy link
Author

bugy commented Apr 22, 2021

Hi @DanielRuf, thanks for the invitation :)

@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: dropdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants