Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on empty config #522

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Warn on empty config #522

merged 2 commits into from
Sep 13, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Sep 12, 2023

Closes #499.

This PR is closely inspired by materialsproject/jobflow#415. Thanks @mcgalcode! 👍

@janosh janosh added testing Test all the things fix Bug fix PR labels Sep 12, 2023
@janosh
Copy link
Member Author

janosh commented Sep 12, 2023

@utf Could you run this shell command?

gh api -i repos/materialsproject/atomate2/branches/main/protection/required_status_checks --method PATCH --input - <<<"$(gh api repos/materialsproject/atomate2/commits/7d16877/check-runs --paginate --jq '{ context: .check_runs[].name }' | jq -s '{ checks: . | unique }')"

Requires brew install gh. It will set all GitHub Actions that triggered for the latest commit of this PR as required status checks. Allows contributors like me to set PRs to auto-merge once all checks are green.

@janosh janosh requested a review from utf September 12, 2023 10:44
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #522 (7d16877) into main (c4f1cb0) will increase coverage by 0.21%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   75.04%   75.26%   +0.21%     
==========================================
  Files          74       74              
  Lines        6572     6577       +5     
  Branches      952      953       +1     
==========================================
+ Hits         4932     4950      +18     
+ Misses       1340     1327      -13     
  Partials      300      300              
Files Changed Coverage Δ
src/atomate2/settings.py 100.00% <100.00%> (+4.25%) ⬆️

... and 1 file with indirect coverage changes

@janosh janosh merged commit ecf80af into main Sep 13, 2023
7 checks passed
@janosh janosh deleted the warn-on-empty-config branch September 13, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR testing Test all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: A blank ~/.atomate2.yaml file causes a crash
1 participant