Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop flake8 #658

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Drop flake8 #658

merged 2 commits into from
Dec 22, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Dec 22, 2023

@utf IIUC, flake8 last remaining use was to lint python code in rST files? I see only 5 rST files and none of them contain Python code. Combined with the fact that ruff now lints Python in doc strings, I think we can get rid of flake8 entirely. Let me know if I missed something.

@janosh janosh added qa linting Linting labels Dec 22, 2023
@janosh janosh enabled auto-merge (squash) December 22, 2023 21:33
@janosh janosh merged commit e71743e into main Dec 22, 2023
6 checks passed
@janosh janosh deleted the drop-flake8 branch December 22, 2023 21:44
@utf utf added the house-keeping Formatting and code quality tweaks label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping Formatting and code quality tweaks linting Linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants