Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyproject.toml malformed [build-system] requires #395

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Conversation

janosh
Copy link
Member

@janosh janosh commented Jun 9, 2024

the unparsable version pin "setuptools_scm[toml]>=6.2<8" (should be >=6.2,<8) seems to have been added 8 months ago in 20581b5462 so I'm surprised no one has reported a failing editable install in the meantime...

requires = ["setuptools>=45", "setuptools_scm[toml]>=6.2<8"]

janosh added 4 commits June 9, 2024 14:15
TOML parse error at line 60, column 12
requires = ["setuptools>=45", "setuptools_scm[toml]>=6.2<8"]
Trailing `<8` is not allowed
@janosh janosh added fix Bug fix PRs pkg Package labels Jun 9, 2024
@janosh
Copy link
Member Author

janosh commented Jun 9, 2024

@mkhorton merging as the same set of errors is also happening on the main branch CI and this PR at least fixes pip install -e ./crystaltoolkit

@janosh janosh merged commit 9d0f896 into main Jun 9, 2024
6 of 7 checks passed
@janosh janosh deleted the fix-pyproject branch June 9, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PRs pkg Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant