Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #114

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Minor updates #114

merged 2 commits into from
Mar 24, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Mar 24, 2023

  • Generator for all native defects
  • Summary for Defect Entries mostly to check Freysoldt correction results

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.18 ⚠️

Comparison is base (e57ea9c) 91.23% compared to head (8e8d904) 91.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   91.23%   91.05%   -0.18%     
==========================================
  Files          11       11              
  Lines        1768     1800      +32     
  Branches      310      316       +6     
==========================================
+ Hits         1613     1639      +26     
- Misses         88       92       +4     
- Partials       67       69       +2     
Impacted Files Coverage Δ
pymatgen/analysis/defects/generators.py 92.61% <70.00%> (-2.93%) ⬇️
pymatgen/analysis/defects/thermo.py 93.29% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmmshn jmmshn merged commit a8907a6 into main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant