Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect Grouping #117

Merged
merged 7 commits into from
Apr 7, 2023
Merged

Defect Grouping #117

merged 7 commits into from
Apr 7, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Apr 6, 2023

Implemented General Grouping of Defects

General Grouping of Defects by structure matching of defect_structure
This ensures that structurally symmetric defects are considered the same regardless of how they were created.

  • First group defects by their name.
  • Then structure match them.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 96.55% and project coverage change: -0.11 ⚠️

Comparison is base (fec83bb) 91.90% compared to head (6cc1dbc) 91.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   91.90%   91.79%   -0.11%     
==========================================
  Files          11       10       -1     
  Lines        1803     1792      -11     
  Branches      318      325       +7     
==========================================
- Hits         1657     1645      -12     
  Misses         81       81              
- Partials       65       66       +1     
Impacted Files Coverage Δ
pymatgen/analysis/defects/thermo.py 93.12% <91.66%> (-0.18%) ⬇️
pymatgen/analysis/defects/utils.py 92.12% <100.00%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmmshn jmmshn marked this pull request as ready for review April 6, 2023 20:50
@jmmshn jmmshn merged commit 08213c8 into main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant