Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumpped Describe, Removed pyrho #132

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Bumpped Describe, Removed pyrho #132

merged 8 commits into from
Jul 24, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Jul 14, 2023

  • Copied the np-pyrho planar spacing function over and removed the import
  • Updated to Describe 2 and bumpped deps accordingly

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (f7e4ef7) 91.12% compared to head (1f835c5) 91.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   91.12%   91.18%   +0.05%     
==========================================
  Files          10       10              
  Lines        1860     1871      +11     
  Branches      344      349       +5     
==========================================
+ Hits         1695     1706      +11     
  Misses         89       89              
  Partials       76       76              
Impacted Files Coverage Δ
pymatgen/analysis/defects/core.py 88.81% <100.00%> (ø)
pymatgen/analysis/defects/finder.py 89.83% <100.00%> (ø)
pymatgen/analysis/defects/utils.py 92.34% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmmshn jmmshn merged commit fd1cda9 into main Jul 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant