Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Formation Energy Diagram Plotting #140

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Changes to Formation Energy Diagram Plotting #140

merged 6 commits into from
Aug 18, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Aug 17, 2023

  • Combine matching formation energy diagrams into one
  • Allow color cycles to be set outside of the plotting functions
  • Put more information in the label via label=latexname

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 76.19% and project coverage change: -0.42% ⚠️

Comparison is base (ec4f507) 91.13% compared to head (fc3add4) 90.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   91.13%   90.71%   -0.42%     
==========================================
  Files          11       11              
  Lines        1985     2004      +19     
  Branches      377      384       +7     
==========================================
+ Hits         1809     1818       +9     
- Misses         94       97       +3     
- Partials       82       89       +7     
Files Changed Coverage Δ
pymatgen/analysis/defects/thermo.py 90.02% <73.68%> (-2.27%) ⬇️
pymatgen/analysis/defects/core.py 89.15% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit eb8e254 into main Aug 18, 2023
6 of 8 checks passed
@jmmshn jmmshn deleted the patch_el branch August 18, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant