Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NamedDefect #146

Merged
merged 18 commits into from
Sep 30, 2023
Merged

Added NamedDefect #146

merged 18 commits into from
Sep 30, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Sep 28, 2023

Summary

Added NamedDefect class to handle edge cases where the construction of a Defect Object is not possible.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (03e6d26) 90.88% compared to head (9a52aa4) 91.21%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   90.88%   91.21%   +0.33%     
==========================================
  Files          11       11              
  Lines        2018     2061      +43     
  Branches      385      391       +6     
==========================================
+ Hits         1834     1880      +46     
+ Misses         96       94       -2     
+ Partials       88       87       -1     
Files Coverage Δ
pymatgen/analysis/defects/thermo.py 91.16% <92.30%> (+1.13%) ⬆️
pymatgen/analysis/defects/core.py 90.88% <76.74%> (+0.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit 3bef7b8 into main Sep 30, 2023
8 of 9 checks passed
@jmmshn jmmshn deleted the nameddefect branch September 30, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant