Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Linting fix. #183

Merged
merged 19 commits into from
Apr 22, 2024
Merged

Major Linting fix. #183

merged 19 commits into from
Apr 22, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Apr 22, 2024

Major Linting fix.

Require annotations for all functions.

Formation Energy Diagram

Use the get_ediff function first.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 79.33579% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 90.28%. Comparing base (98c1022) to head (aaebc19).
Report is 4 commits behind head on main.

❗ Current head aaebc19 differs from pull request most recent head 9fbc07b. Consider uploading reports for the commit 9fbc07b to get more accurate results

Files Patch % Lines
pymatgen/analysis/defects/ccd.py 62.85% 11 Missing and 2 partials ⚠️
pymatgen/analysis/defects/core.py 71.87% 9 Missing ⚠️
pymatgen/analysis/defects/utils.py 79.06% 8 Missing and 1 partial ⚠️
pymatgen/analysis/defects/generators.py 69.56% 6 Missing and 1 partial ⚠️
pymatgen/analysis/defects/finder.py 75.00% 6 Missing ⚠️
pymatgen/analysis/defects/corrections/freysoldt.py 70.58% 5 Missing ⚠️
pymatgen/analysis/defects/supercells.py 70.00% 3 Missing ⚠️
pymatgen/analysis/defects/thermo.py 96.05% 3 Missing ⚠️
pymatgen/analysis/defects/recombination.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   90.39%   90.28%   -0.11%     
==========================================
  Files          11       11              
  Lines        2123     2121       -2     
  Branches      411      394      -17     
==========================================
- Hits         1919     1915       -4     
- Misses        115      123       +8     
+ Partials       89       83       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit c788e64 into main Apr 22, 2024
6 checks passed
@jmmshn jmmshn deleted the js_runs branch April 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant