fix copy-paste error continue-on-error: true in test.yml's pytest step

meant failed test would still show as green in CI!!

.github/workflows/test.yml

@@ -58,7 +58,6 @@ jobs:
         # to update the test durations, run
         # pytest --store-durations --durations-path test_files/.pytest-split-durations
         # and commit the results
-        continue-on-error: true
         run: |
           pytest --cov=pymatgen --splits 10 --group ${{ matrix.split }} --durations-path test_files/.pytest-split-durations
       - name: Upload coverage

pymatgen/core/structure.py

@@ -1867,23 +1867,23 @@ def copy(self, site_properties=None, sanitize=False):
             A copy of the Structure, with optionally new site_properties and
             optionally sanitized.
         """
-        site_props = self.site_properties
+        props = self.site_properties
         if site_properties:
-            site_props.update(site_properties)
+            props.update(site_properties)
         if not sanitize:
             return self.__class__(
                 self._lattice,
                 self.species_and_occu,
                 self.frac_coords,
                 charge=self._charge,
-                site_properties=site_props,
+                site_properties=props,
             )
         reduced_latt = self._lattice.get_lll_reduced_lattice()
         new_sites = []
         for idx, site in enumerate(self):
             frac_coords = reduced_latt.get_fractional_coords(site.coords)
             site_props = {}
-            for prop, val in site_props.items():
+            for prop, val in props.items():
                 site_props[prop] = val[idx]
             new_sites.append(
                 PeriodicSite(

pymatgen/entries/computed_entries.py

@@ -16,7 +16,7 @@
 import os
 import warnings
 from itertools import combinations
-from typing import Literal
+from typing import Literal, cast
 
 import numpy as np
 from monty.json import MontyDecoder, MontyEncoder, MSONable
@@ -142,7 +142,7 @@ def explain(self):
         """
         Return an explanation of how the energy adjustment is calculated.
         """
-        return self.description + f" ({self.value:.3f} eV)"
+        return f"{self.description} ({self.value:.3f} eV)"
 
     def normalize(self, factor):
         """
@@ -222,7 +222,7 @@ def explain(self):
         """
         Return an explanation of how the energy adjustment is calculated.
         """
-        return self.description + f" ({self._adj_per_atom:.3f} eV/atom x {self.n_atoms} atoms)"
+        return f"{self.description} ({self._adj_per_atom:.3f} eV/atom x {self.n_atoms} atoms)"
 
     def normalize(self, factor):
         """
@@ -289,7 +289,7 @@ def explain(self):
         """
         Return an explanation of how the energy adjustment is calculated.
         """
-        return self.description + f" ({self._adj_per_deg:.4f} eV/K/atom x {self.temp} K x {self.n_atoms} atoms)"
+        return f"{self.description} ({self._adj_per_deg:.4f} eV/K/atom x {self.temp} K x {self.n_atoms} atoms)"
 
     def normalize(self, factor):
         """
@@ -491,7 +491,7 @@ def __eq__(self, other: object) -> bool:
         if not all(hasattr(other, attr) for attr in needed_attrs):
             return NotImplemented
 
-        assert isinstance(other, ComputedEntry)  # mypy type narrowing
+        other = cast(ComputedEntry, other)
 
         # Equality is defined based on composition and energy
         # If structures are involved, it is assumed that a {composition, energy} is