Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oddly split strings and a few typos #2285

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Fix oddly split strings and a few typos #2285

merged 5 commits into from
Nov 9, 2021

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 29, 2021

"Lots of " "oddly split" " string in pymatgen", presumably as a result of black formatting.

@janosh
Copy link
Member Author

janosh commented Oct 29, 2021

Dropped some unused variables that flake8 pre-commit hook was complaining about.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.104% when pulling b180cac on janosh:str-fixes into acfe589 on materialsproject:master.

@mkhorton
Copy link
Member

mkhorton commented Nov 9, 2021

Thanks @janosh !

@mkhorton mkhorton merged commit 9276567 into materialsproject:master Nov 9, 2021
@janosh janosh deleted the str-fixes branch November 9, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janosh @coveralls @mkhorton