Don't let tests pollute the pymatgen repo
#3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oordination_numbers_1.png
mv tests/files/chemenv/structure_environments{_files,}
and refactor tests to not pollute git directory if necessary
and corresponding
def tearDown(self):
warnings.simplefilter("default")
example:
def tearDown(self):
del self.ethylene
del self.butadiene
del self.cyclohexene
seems pointless, class is garbage-collected anyway
if __name__ == "__main__":
import unittest
unittest.main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All temporary test files should be written to temporary directories. This PR fixes the worst/most obvious offenders but probably many tests left writing to the current working or module directory.
f94f7a3 delete unused tests/files/chemenv/images/detailed_voronoi_container_coordination_numbers_1.png
bb4f4fa mv tests/files/chemenv/{json_test_files,json} mv tests/files/chemenv/structure_environments{_files,}
dec0193 remove all shutil.rmtree from tests
c3e11d6 pmg test_entrypoint run in tmp_path
7f4bd03 refactor TestVampireCaller
b834872 delete all def setUp(self): warnings.simplefilter("ignore")
e4a84c7 delete questionable def tearDown(self): del self.attrs
a0274db remove all unused unittest.main()