Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google-style doc string return types #3258

Merged
merged 12 commits into from
Aug 21, 2023
Merged

Google-style doc string return types #3258

merged 12 commits into from
Aug 21, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 20, 2023

4276e4e delete analysis/solar/slme.py matrix_eigvals()
fcdd311 fix whitespace
6d60262 mv tests/io/lobster/test_{lobster,inputs}.py
89f454d str concat to f-str
136590b use isinstance(x, Iterable) over hasattr(x, "iter")
4819d94 delete needless bool(...) calls
609cb75 fix bad f-str conversion
ac1247d fix typos, use f-strings, remove docs_rst from .gitattributes linguist-vendored
702b5f7 delete dead code in pymatgen/electronic_structure/boltztrap2.py
5411e52 google-style doc string return types

@janosh janosh added tests Issues with or changes to the pymatgen test suite housekeeping Moving around or cleaning up old code/files labels Aug 20, 2023
@janosh janosh enabled auto-merge (squash) August 20, 2023 20:43
@janosh janosh disabled auto-merge August 20, 2023 20:52
@janosh janosh enabled auto-merge (squash) August 21, 2023 17:29
@janosh janosh added docs Documentation, examples, user guides and removed tests Issues with or changes to the pymatgen test suite labels Aug 21, 2023
@janosh janosh changed the title Remove _files suffix from tests/files/*_files directories Google-style doc string return types Aug 21, 2023
@janosh janosh disabled auto-merge August 21, 2023 17:56
@janosh janosh merged commit 31c9088 into master Aug 21, 2023
@janosh janosh deleted the test-files branch August 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation, examples, user guides housekeeping Moving around or cleaning up old code/files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant