Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend label order in PhononBSPlotter.plot_compare() #3510

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Dec 12, 2023

Thanks @JaGeo for noticing! 👍 Added better testing to make sure this won't regress in the future and clearer doc string to avoid confusion.

@janosh janosh added tests Issues with or changes to the pymatgen test suite fix Bug fix PRs data viz PRs and issues about pymatgen plotting functionality phonon Lattice vibrations labels Dec 12, 2023
@janosh janosh merged commit f0f530d into master Dec 12, 2023
21 of 22 checks passed
@janosh janosh deleted the fix-label-order-ph-bands-plot-compare branch December 12, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data viz PRs and issues about pymatgen plotting functionality fix Bug fix PRs phonon Lattice vibrations tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant