Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic __hash__ for BalancedReaction #3676

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Dynamic __hash__ for BalancedReaction #3676

merged 5 commits into from
Mar 7, 2024

Conversation

DanielYang59
Copy link
Contributor

Summary

The necessity of such method is unclear meanwhile.

janosh
janosh approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍 i added a test

@janosh janosh enabled auto-merge (squash) March 7, 2024 16:16
@janosh janosh added linting Linting and quality assurance analysis Concerning pymatgen.analysis labels Mar 7, 2024
@janosh janosh disabled auto-merge March 7, 2024 19:27
@janosh janosh merged commit 322c924 into materialsproject:master Mar 7, 2024
21 of 22 checks passed
@DanielYang59
Copy link
Contributor Author

i added a test

Thanks a lot. You did much more than you said 😄

@DanielYang59 DanielYang59 deleted the reaction_hash branch March 16, 2024 04:30
@janosh janosh changed the title Add hash for BalancedReaction Dynamic __hash__ for BalancedReaction Apr 12, 2024
@janosh janosh added the performance Some functionality is too slow or regressed label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
analysis Concerning pymatgen.analysis linting Linting and quality assurance performance Some functionality is too slow or regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielYang59 @janosh