Remove unnecessary unittest.TestCase subclassing
#3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
tests
WalkthroughThe recent updates focus on enhancing code maintainability and preparing for future modifications. A significant change is the deprecation of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (80)
- pymatgen/analysis/quasiharmonic.py (3 hunks)
- pymatgen/util/testing/init.py (2 hunks)
- tests/alchemy/test_filters.py (3 hunks)
- tests/analysis/chemenv/utils/test_func_utils.py (2 hunks)
- tests/analysis/magnetism/test_analyzer.py (4 hunks)
- tests/analysis/magnetism/test_heisenberg.py (3 hunks)
- tests/analysis/magnetism/test_jahnteller.py (2 hunks)
- tests/analysis/structure_prediction/test_dopant_predictor.py (2 hunks)
- tests/analysis/structure_prediction/test_substitution_probability.py (3 hunks)
- tests/analysis/test_bond_dissociation.py (2 hunks)
- tests/analysis/test_cost.py (2 hunks)
- tests/analysis/test_energy_models.py (4 hunks)
- tests/analysis/test_ewald.py (3 hunks)
- tests/analysis/test_functional_groups.py (2 hunks)
- tests/analysis/test_graphs.py (2 hunks)
- tests/analysis/test_hhi.py (1 hunks)
- tests/analysis/test_interface_reactions.py (2 hunks)
- tests/analysis/test_molecule_matcher.py (13 hunks)
- tests/analysis/test_phase_diagram.py (9 hunks)
- tests/analysis/test_pourbaix_diagram.py (3 hunks)
- tests/analysis/test_quasi_harmonic_debye_approx.py (4 hunks)
- tests/analysis/test_quasirrho.py (2 hunks)
- tests/analysis/test_reaction_calculator.py (4 hunks)
- tests/analysis/test_structure_analyzer.py (2 hunks)
- tests/apps/battery/test_conversion_battery.py (2 hunks)
- tests/apps/battery/test_insertion_battery.py (2 hunks)
- tests/apps/battery/test_plotter.py (2 hunks)
- tests/apps/borg/test_hive.py (4 hunks)
- tests/apps/borg/test_queen.py (2 hunks)
- tests/command_line/test_chargemol_caller.py (1 hunks)
- tests/command_line/test_critic2_caller.py (3 hunks)
- tests/command_line/test_gulp_caller.py (6 hunks)
- tests/core/test_bonds.py (3 hunks)
- tests/core/test_composition.py (2 hunks)
- tests/core/test_ion.py (1 hunks)
- tests/core/test_periodic_table.py (2 hunks)
- tests/electronic_structure/test_bandstructure.py (2 hunks)
- tests/electronic_structure/test_boltztrap.py (2 hunks)
- tests/electronic_structure/test_boltztrap2.py (7 hunks)
- tests/electronic_structure/test_cohp.py (5 hunks)
- tests/electronic_structure/test_core.py (4 hunks)
- tests/electronic_structure/test_dos.py (5 hunks)
- tests/electronic_structure/test_plotter.py (5 hunks)
- tests/entries/test_compatibility.py (11 hunks)
- tests/entries/test_computed_entries.py (4 hunks)
- tests/entries/test_correction_calculator.py (2 hunks)
- tests/entries/test_exp_entries.py (2 hunks)
- tests/ext/test_cod.py (2 hunks)
- tests/files/.pytest-split-durations (1 hunks)
- tests/io/cp2k/test_outputs.py (2 hunks)
- tests/io/feff/test_inputs.py (6 hunks)
- tests/io/feff/test_outputs.py (2 hunks)
- tests/io/lammps/test_data.py (4 hunks)
- tests/io/lammps/test_outputs.py (3 hunks)
- tests/io/lammps/test_utils.py (2 hunks)
- tests/io/lobster/test_inputs.py (7 hunks)
- tests/io/lobster/test_lobsterenv.py (2 hunks)
- tests/io/test_babel.py (2 hunks)
- tests/io/test_cssr.py (2 hunks)
- tests/io/test_fiesta.py (2 hunks)
- tests/io/test_gaussian.py (3 hunks)
- tests/io/test_jarvis.py (2 hunks)
- tests/io/test_nwchem.py (4 hunks)
- tests/io/test_phonopy.py (3 hunks)
- tests/io/test_prismatic.py (1 hunks)
- tests/io/test_xr.py (2 hunks)
- tests/io/test_xyz.py (2 hunks)
- tests/io/test_zeopp.py (8 hunks)
- tests/io/vasp/test_inputs.py (2 hunks)
- tests/optimization/test_linear_assignment.py (2 hunks)
- tests/phonon/test_plotter.py (4 hunks)
- tests/symmetry/test_analyzer.py (3 hunks)
- tests/symmetry/test_groups.py (3 hunks)
- tests/symmetry/test_settings.py (2 hunks)
- tests/transformations/test_advanced_transformations.py (6 hunks)
- tests/transformations/test_site_transformations.py (5 hunks)
- tests/transformations/test_standard_transformations.py (17 hunks)
- tests/util/test_coord.py (2 hunks)
- tests/util/test_provenance.py (2 hunks)
- tests/util/test_string.py (3 hunks)
Files not reviewed due to errors (1)
- tests_review.py (no review received)
Files skipped from review due to trivial changes (3)
- tests/analysis/test_molecule_matcher.py
- tests/command_line/test_critic2_caller.py
- tests/io/test_jarvis.py
Additional comments: 191
tests/io/test_prismatic.py (1)
- 8-8: The removal of
unittest.TestCaseinheritance fromTestPrismaticaligns with the PR's objective to streamline the testing framework. Ensure that all necessary functionalities, such as assertions, are still correctly implemented and that the tests remain comprehensive and effective.tests/analysis/test_hhi.py (1)
- 8-8: The transition to using
pytestdirectly, without inheriting fromunittest.TestCase, inTestHHIModelis a positive change that aligns with modern testing practices. Ensure that allpytestfeatures are leveraged to maintain comprehensive test coverage.tests/entries/test_exp_entries.py (1)
- 4-4: The update to import
TestCasedirectly and inherit from it inTestExpEntryis a good practice that simplifies the import statements. Ensure that the functionality of thesetUpmethod and otherunittestfeatures are fully preserved and operational.tests/apps/borg/test_queen.py (1)
- 14-14: Removing the inheritance from
unittest.TestCaseinTestBorgQueenaligns with the PR's goal to simplify the testing framework. Ensure that the test assertions remain effective and that the test coverage is comprehensive.tests/ext/test_cod.py (1)
- 4-4: The update to import
TestCasedirectly and inherit from it inTestCODsimplifies the import statements and aligns with the PR's objectives. The combination ofpytestandunittestfeatures, such aspytest.mark.skipif, is effectively used to manage test conditions and dependencies.tests/analysis/test_cost.py (1)
- 3-3: The changes to directly import
TestCaseand update the inheritance inTestCostAnalyzerandTestCostDBare good practices that simplify the code and enhance readability. Ensure that the functionality ofsetUpand otherunittestfeatures are fully preserved and operational.tests/io/test_cssr.py (1)
- 5-5: The update to import
TestCasedirectly and inherit from it inTestCssrsimplifies the import statements and aligns with the PR's objectives. Ensure that the functionality ofsetUpand otherunittestfeatures are fully preserved and operational.tests/io/test_xr.py (1)
- 3-3: The changes to directly import
TestCaseand update the inheritance inTestXrare good practices that simplify the code and enhance readability. Ensure that the functionality ofsetUpand otherunittestfeatures are fully preserved and operational.tests/apps/battery/test_plotter.py (2)
- 4-4: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.- 16-16: The change in class inheritance to directly use
TestCasealigns with the updated import statement and simplifies the codebase.tests/analysis/magnetism/test_heisenberg.py (3)
- 3-3: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.- 14-14: The change in class inheritance to directly use
TestCasealigns with the updated import statement and simplifies the codebase.- 14-14: Transitioning from
setUptosetUpClassfor setup operations can improve test performance by running setup operations once per class instead of before each test method. Ensure that test methods do not depend on the state being reset before each test.tests/io/feff/test_outputs.py (3)
- 3-3: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.- 11-11: The change in class inheritance to directly use
TestCaseforTestFeffLdosaligns with the updated import statement and simplifies the codebase.- 52-52: The change in class inheritance to directly use
TestCaseforTestXmualigns with the updated import statement and simplifies the codebase.tests/analysis/test_energy_models.py (3)
- 12-12: Removing explicit inheritance from
unittest.TestCaseforTestEwaldElectrostaticModelsimplifies the class definition. This assumes the testing framework used does not require subclassing fromTestCaseto run tests, which is common with frameworks like pytest.- 40-40: Removing explicit inheritance from
unittest.TestCaseforTestSymmetryModelsimplifies the class definition, assuming compatibility with the testing framework.- 53-53: Removing explicit inheritance from
unittest.TestCaseforTestIsingModelsimplifies the class definition, assuming compatibility with the testing framework.tests/command_line/test_chargemol_caller.py (1)
- 8-8: Removing explicit inheritance from
unittest.TestCaseforTestChargemolAnalysissimplifies the class definition. This assumes the testing framework used does not require subclassing fromTestCaseto run tests, which is common with frameworks like pytest.tests/analysis/structure_prediction/test_dopant_predictor.py (2)
- 3-3: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.- 15-15: The change in class inheritance to directly use
TestCasealigns with the updated import statement and simplifies the codebase.tests/analysis/structure_prediction/test_substitution_probability.py (3)
- 4-4: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.- 27-27: The change in class inheritance to directly use
TestCaseforTestSubstitutionProbabilityaligns with the updated import statement and simplifies the codebase.- 59-59: The change in class inheritance to directly use
TestCaseforTestSubstitutionPredictoraligns with the updated import statement and simplifies the codebase.tests/io/test_fiesta.py (1)
- 3-3: The update to specifically import
TestCasefrom theunittestmodule simplifies the import statement and enhances code readability.tests/analysis/test_quasirrho.py (1)
- 3-3: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/core/test_bonds.py (2)
- 17-17: The removal of
unittest.TestCaseinheritance forTestCovalentBondsimplifies the test class as it does not utilizesetUportearDownmethods, aligning with the PR's objective.- 47-47: The removal of
unittest.TestCaseinheritance forTestFuncsimplifies the test class as it does not utilizesetUportearDownmethods, aligning with the PR's objective.tests/apps/borg/test_hive.py (1)
- 4-4: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/io/lammps/test_utils.py (1)
- 3-3: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/util/test_string.py (2)
- 37-37: The removal of
unittest.TestCaseinheritance forTestStringifysimplifies the test class as it does not utilizesetUportearDownmethods, aligning with the PR's objective.- 51-51: The removal of
unittest.TestCaseinheritance forTestFuncsimplifies the test class as it does not utilizesetUportearDownmethods, aligning with the PR's objective.tests/analysis/test_functional_groups.py (1)
- 3-3: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/io/test_babel.py (1)
- 4-4: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/alchemy/test_filters.py (1)
- 4-4: The import statement has been updated to import
TestCasedirectly fromunittest, which is a good practice for clarity and consistency.tests/io/cp2k/test_outputs.py (1)
- 3-3: The update to import
TestCasedirectly fromunittestand use it as the base class forTestSetis a good practice for simplifying imports and making the code cleaner.tests/analysis/magnetism/test_jahnteller.py (1)
- 3-3: The change to import
TestCasedirectly and use it for theTestJahnTellerclass aligns with best practices for simplifying imports. This makes the code more readable and maintainable.tests/entries/test_correction_calculator.py (1)
- 3-3: Updating the import to directly use
TestCaseand changing the base class forTestCorrectionCalculatorenhances code clarity and consistency across test files.tests/electronic_structure/test_core.py (1)
- 11-11: Removing the inheritance from
unittest.TestCasefor test classesTestSpin,TestOrbital, andTestMagmomsimplifies the structure of these test classes. This change is in line with the PR's objective to streamline the testing framework by eliminating unnecessary subclassing.tests/analysis/test_ewald.py (1)
- 3-3: The update to import
TestCasedirectly and use it as the base class forTestEwaldSummationandTestEwaldMinimizeris a positive change, making the code more concise and aligned with best practices.tests/symmetry/test_settings.py (1)
- 3-3: The change to import
TestCasedirectly and use it for theTestJonesFaithfulTransformationclass is a good practice, enhancing code readability and maintainability.pymatgen/util/testing/__init__.py (1)
- 15-15: The modification to import
TestCasedirectly and use it as the base class forPymatgenTestis consistent with the PR's objective to streamline the testing framework. This change simplifies the codebase and improves readability.tests/analysis/chemenv/utils/test_func_utils.py (2)
- 16-16: The class
TestFuncUtilshas been correctly updated to no longer inherit fromunittest.TestCase, aligning with the PR's objective to simplify the test framework. Ensure that all test methods within this class are compatible with this change, particularly in the absence ofsetUpandtearDownmethods.- 16-16: All test methods within
TestFuncUtilscorrectly utilizepytestfor assertions and exception testing, making effective use ofassertstatements andpytest.raises. This approach is consistent with the PR's goal of simplifying the test framework by removing unnecessary subclassing fromunittest.TestCase.tests/io/lammps/test_outputs.py (3)
- 5-5: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 17-17: Updating the class
TestLammpsDumpto inherit directly fromTestCaseinstead ofunittest.TestCaseis a good practice that simplifies the code and enhances readability.- 57-57: The update for
TestFuncto inherit fromTestCasedirectly, instead ofunittest.TestCase, is consistent with the PR's goal of simplifying the testing framework. This change improves code readability.tests/apps/battery/test_conversion_battery.py (2)
- 4-4: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 14-14: Updating the class
TestConversionElectrodeto inherit directly fromTestCaseinstead ofunittest.TestCaseis a good practice that simplifies the code and enhances readability.tests/phonon/test_plotter.py (4)
- 4-4: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 17-17: Updating the class
TestPhononDosPlotterto inherit directly fromTestCaseinstead ofunittest.TestCaseis a good practice that simplifies the code and enhances readability.- 55-55: The update for
TestPhononBSPlotterto inherit fromTestCasedirectly, instead ofunittest.TestCase, is consistent with the PR's goal of simplifying the testing framework. This change improves code readability.- 111-111: The change in inheritance for
TestThermoPlotterto directly useTestCaseinstead ofunittest.TestCasealigns with the PR's objectives and simplifies the code structure, making it more readable.tests/analysis/test_quasi_harmonic_debye_approx.py (3)
- 3-3: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 15-15: Renaming the class from
TestQuasiharmociDebyeApproxtoTestQuasiHarmonicDebyeApproxcorrects a typographical error and aligns with the updated naming convention forQuasiHarmonicDebyeApprox. This change enhances code clarity and consistency.- 140-140: The renaming of
TestAnharmonicQuasiharmociDebyeApproxtoTestAnharmonicQuasiHarmonicDebyeApproximproves the naming consistency with theQuasiHarmonicDebyeApproxclass and corrects a typographical error, contributing to better code readability and maintainability.tests/apps/battery/test_insertion_battery.py (2)
- 4-4: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 14-14: Updating the class
TestInsertionElectrodeto inherit directly fromTestCaseinstead ofunittest.TestCaseis a good practice that simplifies the code and enhances readability.tests/io/test_xyz.py (2)
- 3-3: The change from
import unittesttofrom unittest import TestCaseand subsequent updates in class inheritance align with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This modification simplifies the import and makes the code more readable.- 15-15: Updating the class
TestXYZto inherit directly fromTestCaseinstead ofunittest.TestCaseis a good practice that simplifies the code and enhances readability.tests/core/test_ion.py (4)
- 4-4: The update to directly import
TestCasefromunittestis a good practice for clarity and simplicity.- 12-12: The change to have
TestIoninherit directly fromTestCasesimplifies the inheritance and aligns with the PR's objectives.- 12-12: All test methods within
TestIonappear to be correctly implemented and are not negatively impacted by the change in inheritance fromunittest.TestCasetoTestCase.- 12-12: While the changes align with the PR's objectives, consider using
pytestfixtures for setup and teardown processes.pytestfixtures offer more flexibility and idiomatic usage compared to thesetUpmethod fromunittest.tests/symmetry/test_groups.py (2)
- 35-35: The removal of inheritance from
unittest.TestCasefor test classes aligns with the PR's objectives to simplify the testing framework.- 35-35: The test methods are correctly implemented and leverage
pytest'sassertstatements effectively, aligning with the PR's objectives andpytest's idiomatic usage.tests/io/test_zeopp.py (6)
- 34-34: The change from
unittest.TestCasetoTestCasealigns with the PR's objective of streamlining the testing framework. Good job on updating the import statement and class declaration accordingly.- 77-77: The update from
unittest.TestCasetoTestCaseis consistent and correctly implemented.- 121-121: Consistent update to use
TestCasedirectly, following the PR's objective to streamline the testing framework.- 152-152: Correctly updated to use
TestCasedirectly, which simplifies the test class declaration.- 176-176: The update to use
TestCasedirectly is correctly implemented, aligning with the PR's goal of simplifying the test framework.- 191-191: The change to use
TestCasedirectly is correctly implemented, contributing to the simplification of the test framework.tests/optimization/test_linear_assignment.py (1)
- 12-12: The update from
unittest.TestCasetoTestCaseis correctly implemented, aligning with the PR's objective to streamline the testing framework.tests/analysis/test_structure_analyzer.py (1)
- 40-40: The update from
unittest.TestCasetoTestCaseis correctly implemented, aligning with the PR's objective to streamline the testing framework.tests/util/test_provenance.py (1)
- 25-25: The update from
unittest.TestCasetoTestCaseis correctly implemented, aligning with the PR's objective to streamline the testing framework.tests/io/test_phonopy.py (3)
- 5-5: The change from
import unittesttofrom unittest import TestCasesimplifies the import statement and aligns with the PR's objective of streamlining the testing framework by removing unnecessary subclassing. This is a good practice as it makes the code cleaner and more readable.- 159-159: Changing the inheritance of the
TestPhonopyFromForceConstantsclass to directly useTestCasesimplifies the class declaration and is consistent with the updated import statement. This change enhances readability and maintainability of the test code.- 209-209: Removing the inheritance from
unittest.TestCasefor theTestGruneisenclass aligns with the PR's objective of streamlining the testing framework by eliminating unnecessary subclassing. This simplification contributes to the overall readability and maintainability of the test code.tests/analysis/test_pourbaix_diagram.py (3)
- 5-5: The change to directly import
TestCasefromunittestsimplifies the import statements and aligns with the PR's objective to streamline the testing framework. Good job on making the test code more concise and readable.- 101-101: Changing the inheritance of
TestPourbaixDiagramfromunittest.TestCasetoTestCasesimplifies the code and aligns with the PR's objective. Ensure that this change does not affect any setup or teardown processes if they were previously utilized.- 291-291: Changing the inheritance of
TestPourbaixPlotterfromunittest.TestCasetoTestCaseis consistent with the PR's goals of simplifying the test code. As with other changes, ensure that this does not impact any setup or teardown processes if they were in use.tests/transformations/test_site_transformations.py (4)
- 81-81: The change to inherit
TestReplaceSiteSpeciesTransformationfromTestCasealigns well with the PR's objective of streamlining the testing framework by removing unnecessary subclassing fromunittest.TestCase.- 113-113: The change to inherit
TestRemoveSitesTransformationfromTestCaseis consistent with the PR's goal of simplifying the test framework. Good job on making the test classes more concise.- 145-145: The update to
TestInsertSitesTransformationto inherit fromTestCaseis a positive step towards simplifying the test codebase. This change enhances readability and maintainability.- 182-182: The modification in
TestPartialRemoveSitesTransformationto inherit fromTestCaseinstead ofunittest.TestCaseis in line with the PR's objectives. This simplifies the inheritance structure for test classes.tests/electronic_structure/test_boltztrap.py (1)
- 30-30: The update to
TestBoltztrapAnalyzerto inherit fromTestCaseis in alignment with the PR's goal of optimizing the testing framework by eliminating unnecessary subclassing. This is a well-executed change.tests/electronic_structure/test_boltztrap2.py (6)
- 44-44: The change to inherit
TestVasprunBSLoaderfromTestCasealigns with the PR's objective of streamlining the testing framework. This is a positive step towards simplifying the test codebase.- 84-84: The update to
TestBandstructureLoaderto inherit fromTestCaseis consistent with the PR's goal of simplifying the test framework. This enhances the readability and maintainability of the test classes.- 113-113: The modification in
TestVasprunLoaderto inherit fromTestCaseinstead ofunittest.TestCaseis in line with the PR's objectives. This simplifies the inheritance structure for test classes.- 133-133: The change to inherit
TestBztInterpolatorfromTestCaseis a good example of streamlining the testing framework by removing unnecessary subclassing. This change is well-aligned with the PR's objectives.- 210-210: The update to
TestBztTransportPropertiesto inherit fromTestCaseis in alignment with the PR's goal of optimizing the testing framework. This is a well-executed change that simplifies the test codebase.- 310-310: The modification in
TestBztPlotterto inherit fromTestCaseinstead ofunittest.TestCaseis consistent with the PR's objectives of simplifying the test framework. This enhances the readability and maintainability of the test classes.tests/analysis/magnetism/test_analyzer.py (2)
- 4-4: The change to import
TestCasedirectly fromunittestis correct and aligns with the PR's objective to streamline the testing framework.- 25-25: The update to the class declaration to inherit from
TestCaseis appropriate and improves consistency and readability.pymatgen/analysis/quasiharmonic.py (1)
- 362-367: The implementation of the deprecation warning for
QuasiharmonicDebyeApproxis correctly done using the@deprecateddecorator. The message is clear, and the deprecation and removal dates are appropriately specified.tests/util/test_coord.py (1)
- 4-4: The change to import
TestCasedirectly fromunittestis correct and aligns with the PR's objective to streamline the testing framework.tests/analysis/test_bond_dissociation.py (2)
- 4-4: The updated import statement correctly imports
TestCasefromunittest, streamlining the import process.- 14-14: The
TestBondDissociationclass correctly inherits fromTestCase, utilizing thesetUpmethod for initializing test data. This is a valid and effective use ofunittest.TestCaseinheritance.tests/io/feff/test_inputs.py (2)
- 4-4: The updated import statement correctly imports
TestCasefromunittest, aligning with the PR's objective to streamline the testing framework.- 30-30: The updated class definitions for
TestHeader,TestFeffAtoms,TestFeffTags,TestFeffPot, andTestPathscorrectly inherit fromTestCase. This change simplifies the inheritance structure and is in line with the PR's objectives.Also applies to: 59-59, 146-146, 211-211, 244-244
tests/io/test_gaussian.py (3)
- 3-3: The change in the import statement aligns with the PR's objective of streamlining the testing framework by directly importing
TestCase. This simplifies the code and improves readability.- 16-16: The update to the
TestGaussianInputclass to inherit directly fromTestCaseis in line with the PR's goal of simplifying the test framework. This change is appropriate as the class utilizessetUp, a method provided byTestCase.- 254-254: The update to the
TestGaussianOutputclass to inherit directly fromTestCaseis in line with the PR's goal of simplifying the test framework. This change is appropriate as the class utilizessetUp, a method provided byTestCase.tests/analysis/test_reaction_calculator.py (3)
- 5-5: The change in the import statement aligns with the PR's objective of streamlining the testing framework by directly importing
TestCase. This simplifies the code and improves readability.- 290-290: The update to the
TestBalancedReactionclass to inherit directly fromTestCaseis in line with the PR's goal of simplifying the test framework. This change is appropriate as the class utilizessetUp, a method provided byTestCase.- 337-337: The update to the
TestComputedReactionclass to inherit directly fromTestCaseis in line with the PR's goal of simplifying the test framework. This change is appropriate as the class utilizessetUp, a method provided byTestCase.tests/entries/test_computed_entries.py (4)
- 6-6: The change to directly import
TestCasefromunittestsimplifies the code and improves readability. Good job on streamlining the import statements.- 92-92: Changing the inheritance of
TestComputedEntryto directly useTestCasealigns with the PR's goal of simplifying the test framework. This is a positive change.- 241-241: The update to
TestComputedStructureEntryto inherit directly fromTestCaseis consistent with the PR's objectives and enhances code clarity.- 438-438: The modification in
TestGibbsComputedStructureEntryto inherit fromTestCasedirectly is a good practice, making the test classes more concise.tests/analysis/test_interface_reactions.py (2)
- 3-3: Directly importing
TestCasefromunittestsimplifies the code and improves readability, aligning with the PR's goal of streamlining the testing framework.- 20-20: Changing the inheritance of
TestInterfaceReactionto directly useTestCaseis consistent with the PR's objectives, simplifying the test framework and improving code readability.tests/core/test_periodic_table.py (1)
- 537-537: The changes to
TestDummySpeciesremove inheritance fromunittest.TestCase, aligning with the PR's objective to streamline the testing framework. This transition leveragespytest's capability to run tests without the need forunittest.TestCaseinheritance, simplifying the test code structure.tests/electronic_structure/test_bandstructure.py (2)
- 5-5: The change to specifically import
TestCasefromunittestenhances code clarity and conciseness.- 26-26: The update to
TestKpointto inherit fromTestCasedirectly is a good practice, improving code readability and consistency with the modified import statement.tests/transformations/test_standard_transformations.py (17)
- 8-8: The import statement for
TestCaseis correctly updated to reflect the removal ofunittest.TestCaseinheritance. This change aligns with the PR's objective to streamline the testing framework by removing unnecessary subclassing.- 41-47: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [44-66]
The
TestRotationTransformationsclass correctly inherits fromTestCaseinstead ofunittest.TestCase. This change is consistent with the PR's goal. However, it's important to ensure that all instances whereself.assert*methods fromunittest.TestCaseare used are still valid and functional, as these are essential for the test's assertions.Verification successful
The verification process revealed that there are no occurrences of
self.assert*methods within theTestRotationTransformationsclass in thetests/transformations/test_standard_transformations.pyfile. Therefore, the concern about ensuring the functionality ofself.assert*methods due to the change in inheritance fromunittest.TestCasetoTestCasedoes not apply in this context.* 66-66: The `TestRemoveSpeciesTransformation` class no longer inherits from `TestCase` or any other class. This change simplifies the test class as per the PR's objectives. Ensure that pytest-compatible assertion statements are used throughout this test class. * 83-83: Similar to the previous comment, the `TestSubstitutionTransformation` class has been updated to not inherit from `TestCase`. This is in line with the PR's goal to streamline the testing framework. Again, ensure that pytest-compatible assertion statements are used. * 111-111: The `TestSupercellTransformation` class correctly inherits from `TestCase`, aligning with the PR's objectives. As with other test classes, verify the continued functionality of `self.assert*` methods. * 170-170: The `TestOxidationStateDecorationTransformation` class does not inherit from `TestCase`, which is consistent with the PR's goal to remove unnecessary subclassing. Ensure pytest-compatible assertions are used. * 187-187: The `TestAutoOxiStateDecorationTransformation` class follows the pattern of not inheriting from `TestCase`, aligning with the PR's objectives. Confirm the use of pytest-compatible assertions. * 202-202: The `TestOxidationStateRemovalTransformation` class is updated to not inherit from `TestCase`, which is in line with the PR's goal. Ensure that pytest-compatible assertion statements are used. * 221-221: The `TestPartialRemoveSpecieTransformation` class no longer inherits from `TestCase`, aligning with the PR's objectives. Confirm the use of pytest-compatible assertions in this test class. * 260-260: The `TestOrderDisorderedStructureTransformation` class has been updated to not inherit from `TestCase`, which is consistent with the PR's goal. Ensure that pytest-compatible assertion statements are used. * 362-362: The `TestPrimitiveCellTransformation` class correctly inherits from `TestCase`, aligning with the PR's objectives. Verify the continued functionality of `self.assert*` methods. * 394-394: The `TestConventionalCellTransformation` class does not inherit from `TestCase`, which is in line with the PR's goal to remove unnecessary subclassing. Ensure pytest-compatible assertions are used. * 408-408: The `TestPerturbStructureTransformation` class follows the pattern of not inheriting from `TestCase`, aligning with the PR's objectives. Confirm the use of pytest-compatible assertions. * 445-445: The `TestDeformStructureTransformation` class has been updated to not inherit from `TestCase`, which is consistent with the PR's goal. Ensure that pytest-compatible assertion statements are used. * 474-474: The `TestDiscretizeOccupanciesTransformation` class does not inherit from `TestCase`, aligning with the PR's objectives. Confirm the use of pytest-compatible assertions in this test class. * 510-510: The `TestChargedCellTransformation` class correctly inherits from `TestCase`, aligning with the PR's objectives. As with other test classes, verify the continued functionality of `self.assert*` methods. * 522-522: The `TestScaleToRelaxedTransformation` class does not inherit from `TestCase`, which is in line with the PR's goal to remove unnecessary subclassing. Ensure pytest-compatible assertions are used.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that self.assert* methods are still accessible and functional without direct unittest.TestCase inheritance. grep -R "self.assert" tests/transformations/test_standard_transformations.pyLength of output: 76
tests/electronic_structure/test_plotter.py (6)
- 6-6: The import statement for
TestCaseis correctly updated to reflect the removal ofunittest.TestCaseinheritance. This change aligns with the PR's objective to streamline the testing framework by removing unnecessary subclassing.- 182-182: The
TestBSPlotterProjectedclass correctly inherits fromTestCaseinstead ofunittest.TestCase. This change is consistent with the PR's goal. However, it's important to ensure that all instances whereself.assert*methods fromunittest.TestCaseare used are still valid and functional, as these are essential for the test's assertions.- 211-211: The
TestBSDOSPlotterclass no longer inherits fromTestCaseor any other class. This change simplifies the test class as per the PR's objectives. Ensure that pytest-compatible assertion statements are used throughout this test class.- 250-250: The
TestPlotBZclass correctly inherits fromTestCase, aligning with the PR's objectives. As with other test classes, verify the continued functionality ofself.assert*methods.Verification successful
The expanded search for assertions within
tests/electronic_structure/test_plotter.pyhas revealed a variety of assertion statements, including direct assertions likeassert condition, "message"and usage ofassert_allclosefromnumpy.testing. This indicates that the test file employs a mix of standard Python assertions and specialized assertion methods for numerical testing.Given this information, it's clear that the
TestPlotBZclass, along with other test classes in the file, do not rely solely onself.assert*methods fromunittest.TestCasefor assertions. They also use direct Python assertions andassert_allclosefor numerical comparisons. This approach is valid and can coexist withunittest's assertion methods, offering flexibility in testing conditions, especially for numerical data where close approximations are considered acceptable.Therefore, the initial comment about verifying the continued functionality of
self.assert*methods, while relevant, overlooks the broader context of how assertions are implemented in the test suite. The tests are not limited tounittest.TestCase's assertion methods but also include direct Python assertions and specialized numerical assertions, which are equally important for the test suite's functionality.* 295-295: The `TestBoltztrapPlotter` class correctly inherits from `TestCase`, aligning with the PR's objectives. Verify the continued functionality of `self.assert*` methods.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that self.assert* methods are still accessible and functional without direct unittest.TestCase inheritance. grep -R "self.assert" tests/electronic_structure/test_plotter.pyLength of output: 64
Script:
#!/bin/bash # Broaden the search to capture any usage of assertion methods in test_plotter.py, including potential variations or alternative mechanisms. grep -R "assert" tests/electronic_structure/test_plotter.pyLength of output: 9972
Verification successful
Given the absence of output from the initial script, it's essential to broaden our search to understand how the
TestBoltztrapPlotterclass is handling assertions. We'll look for any form of assertion or validation mechanism used within this class, including directassertstatements or alternative methods that could serve the same purpose asself.assert*methods.
The output from the script reveals that the
TestBoltztrapPlotterclass and its methods utilize a variety of assertion mechanisms, including directassertstatements andassert_allclosefromnumpy.testing. This indicates that whileself.assert*methods fromunittest.TestCasemight not be directly used, the test cases still effectively perform assertions to verify test conditions through these alternative mechanisms.Given this information, it can be concluded that the functionality of assertions within the
TestBoltztrapPlotterclass is maintained, albeit through different assertion techniques than theself.assert*methods provided byunittest.TestCase. This aligns with the original review comment's intent to verify the continued functionality of assertion mechanisms in the context of the PR's objectives.* 2-9: > 📝 **NOTE** > This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [510-510]Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that self.assert* methods are still accessible and functional without direct unittest.TestCase inheritance. grep -R "self.assert" tests/electronic_structure/test_plotter.pyLength of output: 64
Script:
#!/bin/bash # Broaden the search to include any form of assertions within the TestBoltztrapPlotter class. grep -R "assert" tests/electronic_structure/test_plotter.pyLength of output: 9972
The
TestCohpPlotterclass correctly inherits fromTestCase, aligning with the PR's objectives. As with other test classes, verify the continued functionality ofself.assert*methods.Verification successful
Given the absence of direct "self.assert*" method calls in the
test_plotter.pyfile, it's essential to further investigate how theTestCohpPlotterclass performs assertions and whether it indirectly inherits fromunittest.TestCaseor utilizes another mechanism for assertions. To gain a clearer understanding, let's inspect the class definition and its inheritance structure.
The
TestCohpPlotterclass inherits fromPymatgenTest, not directly fromunittest.TestCase. This indicates that the assertion functionality might be provided through thePymatgenTestclass. To fully understand howTestCohpPlotteraccesses assertion methods, we need to investigate thePymatgenTestclass's inheritance chain or its implementation to confirm if it indirectly inherits fromunittest.TestCaseor provides a similar assertion mechanism.
The
PymatgenTestclass, from whichTestCohpPlotterinherits, extendsunittest.TestCase. This is confirmed by the output indicating thatPymatgenTestis defined as a subclass ofTestCaseand provides additional assertion methods for array and string comparison. Therefore, theTestCohpPlotterclass, through its inheritance fromPymatgenTest, indirectly inherits fromunittest.TestCaseand has access to all theself.assert*methods provided byunittest.TestCase, in addition to any custom assertion methods defined inPymatgenTest.This confirms that the original review comment is consistent with the codebase, as the
TestCohpPlotterclass, through its inheritance chain, maintains access to theself.assert*methods necessary for its testing functionality.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that self.assert* methods are still accessible and functional without direct unittest.TestCase inheritance. grep -R "self.assert" tests/electronic_structure/test_plotter.pyLength of output: 64
Script:
#!/bin/bash # Inspect the TestCohpPlotter class definition and its inheritance grep -A 5 "class TestCohpPlotter" tests/electronic_structure/test_plotter.pyLength of output: 367
Script:
#!/bin/bash # Investigate the PymatgenTest class's definition and its inheritance chain or implementation grep -A 5 "class PymatgenTest" $(fd .py)Length of output: 20795
tests/symmetry/test_analyzer.py (3)
- 3-3: The update to import
TestCasedirectly fromunittestinstead of importing the entire module is a good practice for clarity and potentially reduces the namespace clutter.- 370-370: The change from subclassing
unittest.TestCasetoTestCasedirectly is consistent with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This change simplifies the test class declaration and aligns with the updated import statement.- 626-626: Similar to the previous comment, updating the test class to subclass
TestCasedirectly instead ofunittest.TestCaseis a positive change that simplifies the code and makes it more readable. This is in line with the PR's goals and the changes made throughout the file.tests/core/test_composition.py (1)
- 798-798: Removing inheritance from
unittest.TestCaseinTestChemicalPotentialaligns with the PR's goal to simplify the test framework. Ensure that pytest fixtures and markers are leveraged appropriately for setup and teardown processes if needed, replacing anysetUportearDownmethods fromunittest.TestCase.tests/io/lobster/test_lobsterenv.py (3)
- 4-4: The change to directly import
TestCasefromunittestis a good practice for clarity and conciseness.- 29-29: The update to the class declaration to inherit from
TestCasedirectly is aligned with the PR's objective and simplifies the inheritance structure.- 29-29: While the
setUpmethod is quite extensive, it's necessary for the comprehensive testing ofLobsterNeighbors. Consider breaking it down if it becomes too unwieldy in the future. Additionally, adding more comments and docstrings to test methods could enhance clarity and maintainability.tests/transformations/test_advanced_transformations.py (6)
- 73-73: The class
TestSuperTransformationno longer inherits fromunittest.TestCase, aligning with the PR's objective to streamline the testing framework by removing unnecessary subclassing. This change is consistent across the file for all test classes.- 253-253: The method
test_apply_transformationinTestSubstitutionPredictorTransformationcorrectly tests the functionality of theSubstitutionPredictorTransformation. It's good practice to assert the expected outcomes to ensure the transformation behaves as intended.- 253-253: In
TestSubstitutionPredictorTransformation, the methodtest_as_dicteffectively tests the serialization and deserialization of the transformation. This is crucial for ensuring that transformations can be saved and loaded correctly, preserving their state.- 253-253: The use of
pytest.mark.skipifdecorators throughout the file is a good practice for conditionally skipping tests based on the environment or external dependencies. This ensures that the test suite remains robust and flexible.- 253-253: The transformation classes, such as
TestMagOrderingTransformation,TestDopingTransformation,TestSlabTransformation, etc., are tested thoroughly with various scenarios. This comprehensive testing approach is commendable as it ensures the reliability and correctness of the transformations.- 253-253: The file makes extensive use of
assertstatements to verify the correctness of transformations. This is essential for maintaining the integrity of the transformations and ensuring they perform as expected under different conditions.tests/electronic_structure/test_dos.py (6)
- 4-4: The import statement for
TestCasefrom theunittestmodule is correctly updated to reflect the PR's objective of streamlining the testing framework by removing unnecessary subclassing. This change is consistent across the file for all test classes.- 19-19: The class
TestDoscorrectly inherits fromTestCase, aligning with the PR's objective. The presence of asetUpmethod justifies the use ofTestCaseinheritance for this particular test class, as it utilizes setup functionality.- 54-54: The class
TestFermiDosis structured similarly toTestDos, with appropriate use ofTestCaseinheritance due to the presence of asetUpmethod. This is in line with the PR's goals.- 101-101: The class
TestCompleteDosfollows the same pattern as the previous classes, correctly inheriting fromTestCase. The use of asetUpmethod for test setup is noted and aligns with the PR's objectives.- 321-321: The class
TestSpinPolarizationinherits fromTestCasewithout asetUpmethod. This might initially seem unnecessary, but it's important to remember that otherTestCasefunctionalities, such as assertions, are still utilized. This inheritance is therefore justified.- 328-328: The class
TestLobsterCompleteDoscorrectly inherits fromTestCase, utilizing asetUpmethod to prepare test data. This aligns with the PR's objectives and justifies the inheritance.tests/analysis/test_graphs.py (2)
- 7-7: The import of
TestCasefromunittestis correctly updated to streamline the testing framework by removing unnecessary subclassing fromunittest.TestCase. This change aligns with the PR objectives.- 490-490: The change in inheritance for
TestMoleculeGraphto directly inherit fromTestCaseinstead ofunittest.TestCaseis correctly implemented. This simplifies the code and aligns with the PR's objective to streamline the testing framework.tests/analysis/test_phase_diagram.py (10)
- 8-8: The import statement for
TestCasehas been updated to directly import fromunittest. This change aligns with the PR's objective to streamline the testing framework by removing unnecessary subclassing fromunittest.TestCase.- 40-40: The class
TestPDEntrynow correctly inherits fromTestCase, simplifying the import and making the code cleaner.- 116-116: The class
TestTransformedPDEntryhas been updated to inherit fromTestCase, which is consistent with the PR's goal of simplifying the test framework.- 116-116: The class
TestPhaseDiagramdoes not inherit fromTestCase. Given the PR's objectives to streamline the testing framework, please verify if this was an intentional decision or an oversight.- 643-643: The class
TestGrandPotentialPhaseDiagramcorrectly inherits fromTestCase, aligning with the PR's objectives to streamline the testing framework.- 679-679: The class
TestCompoundPhaseDiagramcorrectly inherits fromTestCase, aligning with the PR's objectives to streamline the testing framework.- 705-705: The class
TestPatchedPhaseDiagramcorrectly inherits fromTestCase, aligning with the PR's objectives to streamline the testing framework.- 836-836: The class
TestReactionDiagramcorrectly inherits fromTestCase, aligning with the PR's objectives to streamline the testing framework.- 876-876: The class
TestPDPlottercorrectly inherits fromTestCase, aligning with the PR's objectives to streamline the testing framework.- 955-955: The class
TestUtilityFunctiondoes not inherit fromTestCase, which seems appropriate as it appears to be a utility class rather than a test class. This aligns with the design choice to only modify test classes.tests/io/vasp/test_inputs.py (2)
- 9-9: The change from
unittest.TestCasetoTestCase, withTestCasebeing explicitly imported fromunittest, simplifies the import statements and makes the code cleaner. This aligns with the PR's objective to streamline the testing framework.- 1000-1000: The update to make
TestPotcarSingleinherit fromTestCaseinstead ofunittest.TestCaseis consistent with the simplified import statement. This change should not affect the functionality of the test cases as long asTestCaseis correctly imported fromunittest, which it is.tests/io/lammps/test_data.py (5)
- 6-6: The change from
import unittesttofrom unittest import TestCaseis consistent with the PR's objective to streamline the testing framework by removing unnecessary subclassing fromunittest.TestCase. This change simplifies the import statement and directly importsTestCase, which is the only component used from theunittestmodule in this file.- 3-9: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [14-14]
The class
TestLammpsBoxnow correctly inherits fromTestCaseinstead ofunittest.TestCase. This change aligns with the PR's objective and simplifies the class declaration.
- 521-521: The class
TestTopologynow correctly inherits fromTestCaseinstead ofunittest.TestCase. This change aligns with the PR's objective and simplifies the class declaration.- 753-753: The class
TestFuncnow correctly inherits fromTestCaseinstead ofunittest.TestCase. This change aligns with the PR's objective and simplifies the class declaration.- 785-785: The class
TestCombinedDatanow correctly inherits fromTestCaseinstead ofunittest.TestCase. This change aligns with the PR's objective and simplifies the class declaration.tests/electronic_structure/test_cohp.py (5)
- 4-4: The import from
unittestis updated to specifically importTestCase, aligning with the PR's objective to streamline the testing framework by removing unnecessary subclassing fromunittest.TestCase.- 23-23: The
TestCohpclass now inherits fromTestCaseinstead ofunittest.TestCase. This change simplifies the import statement and is consistent with the PR's goal to enhance code readability and maintainability.- 87-87: The
TestIcohpValueclass has been updated to inherit directly fromTestCase, which is in line with the PR's objectives to remove unnecessary subclassing and streamline the testing framework.- 165-165: The
TestCombinedIcohpclass's inheritance has been changed to directly useTestCase, further contributing to the PR's aim of simplifying the test code structure and improving maintainability.- 1248-1248: The
TestMethodclass is introduced, inheriting fromTestCase. This addition seems to be part of the broader scope of changes mentioned in the PR, possibly aimed at enhancing the project's code quality through better testing practices.tests/io/lobster/test_inputs.py (8)
- 2033-2033: The test suite for
Bandoverlapsclass is well-structured and covers a range of scenarios including spin-polarized calculations and checks for good quality based on maximum deviation and occupied bands. It's important to ensure that the test data used reflects realistic scenarios thatBandoverlapsmight encounter in actual use cases.- 2192-2192: The
TestGrosspopclass provides a concise and effective test for theGrosspopclass, ensuring that gross population data is correctly parsed and can be integrated with aStructureobject. It's crucial that the test data accurately represents the output from Lobster to validate the parsing logic effectively.- 2192-2192: The
TestSitePotentialsclass effectively tests the parsing and usage of site potential data from Lobster outputs. Including tests for integration withStructureobjects ensures that site potential data can be used in broader pymatgen workflows.- 2192-2192: The
TestMadelungEnergiesclass provides targeted tests for theMadelungEnergiesclass, ensuring that Madelung energies and related properties are correctly parsed from Lobster outputs. This is crucial for accurate energy calculations in materials science applications.- 2192-2192: The
TestLobsterMatricesclass thoroughly tests the parsing and handling of various matrix types from Lobster outputs. It's important to ensure that the tests cover a wide range of scenarios, including different spin states and matrix properties, to validate the robustness of theLobsterMatricesclass.- 2192-2192: The
TestWavefunctionclass effectively tests the functionality of theWavefunctionclass, ensuring that wavefunction data from Lobster outputs can be parsed and converted into volumetric data for visualization and analysis. This is a key feature for understanding electronic properties at a detailed level.- 2192-2192: The
TestSitePotentialsclass provides comprehensive tests for theSitePotentialclass, ensuring that site potential data is accurately parsed and can be integrated with pymatgen'sStructureobjects. This facilitates the use of site potential data in materials analysis workflows.- 2192-2192: The
TestUtilsclass tests the utility functions for generating all possible basis function combinations based on minimum and maximum basis sets. This is crucial for automating the setup of Lobster calculations where the basis set can significantly impact the results. Ensuring that the utility functions generate accurate and complete combinations is essential for reliable calculations.tests/files/.pytest-split-durations (1)
- 566-572: The renaming of test methods in the
quasi_harmonic_debye_approxmodule toTestQuasiHarmonicDebyeApproxand subsequent method names enhances consistency and clarity in the test suite. This change aligns well with the PR's objectives of improving code quality and readability.
| @@ -34,7 +32,7 @@ | |||
| ).split() | |||
|
|
|||
|
|
|||
| class TestPointGroup(unittest.TestCase): | |||
| class TestPointGroup: | |||
There was a problem hiding this comment.
There's a commented TODO in the test_is_sub_super_group method. It's important to address this to ensure the test suite is comprehensive and all intended test cases are implemented.
Would you like assistance in implementing the test case mentioned in the TODO comment?
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- tests/command_line/test_critic2_caller.py (4 hunks)
- tests/files/.pytest-split-durations (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- tests/command_line/test_critic2_caller.py
- tests/files/.pytest-split-durations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many test classes don't have
setUportearDownmethods and so don't need to inherit fromunittest.TestCasealso rename
Quasi(h->H)armonicDebyeApproxand deprecate old nameSummary by CodeRabbit
QuasiharmonicDebyeApproxin favor ofQuasiHarmonicDebyeApprox, with a clear deprecation and removal timeline.unittest.TestCasewithTestCasefor improved readability and maintainability across numerous test files.quasi_harmonic_debye_approxmodule for consistency and clarity in the test suite.