Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HSE-specific vdW parameters for dftd3 and dftd3-bj to MPHSERelaxSet. #3914

Closed
wants to merge 9 commits into from
Closed

Add HSE-specific vdW parameters for dftd3 and dftd3-bj to MPHSERelaxSet. #3914

wants to merge 9 commits into from

Conversation

hongyi-zhao
Copy link
Contributor

@hongyi-zhao hongyi-zhao commented Jul 7, 2024

Add HSE-specific vdW parameters for dftd3 and dftd3-bj to MPHSERelaxSet. For the related discussion and information, see below:
https://www.vasp.at/forum/viewtopic.php?t=19551
https://github.com/dftd3/simple-dftd3/blob/3a50cbdf8566b3caa8760499ae21746ec9a5e535/assets/parameters.toml#L80-L82

@hongyi-zhao
Copy link
Contributor Author

hongyi-zhao commented Jul 8, 2024

This PR may not be a good way. Another way I can think of is to modify vdw_parameters.yaml as follows:

diff --git a/src/pymatgen/io/vasp/vdW_parameters.yaml b/src/pymatgen/io/vasp/vdW_parameters.yaml
index 6708fbd1e..8adcda275 100644
--- a/src/pymatgen/io/vasp/vdW_parameters.yaml
+++ b/src/pymatgen/io/vasp/vdW_parameters.yaml
@@ -3,8 +3,15 @@ dftd2:
     IVDW: 1
 dftd3:
     IVDW: 11
+    hse:
+        VDW_SR: 1.129
+        VDW_S8: 0.109    
 dftd3-bj:
     IVDW: 12
+    hse:
+        VDW_A1: 0.383
+        VDW_S8: 2.310
+        VDW_A2: 5.685    
 dftd4:
     IVDW: 13
 ts:

However, I could not effectively implement the corresponding code adjustments in other parts of pymatgen for this alternative method.

@hongyi-zhao
Copy link
Contributor Author

hongyi-zhao commented Jul 8, 2024

Also see here for the related discussion.

@shyuep
Copy link
Member

shyuep commented Jul 8, 2024

Pls add tests for the new parameters. @mkhorton What needs to be done about the hashes? I still maintain the hashes are creating more headache than they solve.

@hongyi-zhao
Copy link
Contributor Author

@shyuep What do you mean by saying the hashes here?

@shyuep
Copy link
Member

shyuep commented Jul 8, 2024

The failing tests are due to a hash check whenever input set yaml files are modified.

@hongyi-zhao
Copy link
Contributor Author

hongyi-zhao commented Jul 8, 2024

The failing tests are due to a hash check whenever input set yaml files are modified.

  1. I should always create a PR branch based on materialsproject:master of pymatgen instead of my local master branch which includes other unmerged PRs I have made, which triggered this issue.
  2. Using additional hash checks over these input sets of YAML files is unnecessary and troublesome, because they are all simple text files, and git itself already can trace them perfectly and is designed for such a job.

@hongyi-zhao hongyi-zhao closed this by deleting the head repository Jul 23, 2024
@hongyi-zhao hongyi-zhao changed the title Add HSE-specific vdW parameters to MPHSERelaxSet Add HSE-specific vdW parameters dftd3 and dftd3-bj to MPHSERelaxSet. Jul 27, 2024
@hongyi-zhao hongyi-zhao changed the title Add HSE-specific vdW parameters dftd3 and dftd3-bj to MPHSERelaxSet. Add HSE-specific vdW parameters for dftd3 and dftd3-bj to MPHSERelaxSet. Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants