Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in-place VaspInput.incar updates having no effect if incar is dict (not Incar instance) #4052

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix in-place VaspInput.incar updates having no effect if incar is dict (not Incar instance) #4052

merged 2 commits into from
Sep 7, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Sep 7, 2024

closes #4051

@janosh janosh added io Input/output functionality fix Bug fix PRs vasp Vienna Ab initio Simulation Package labels Sep 7, 2024
@janosh janosh enabled auto-merge (squash) September 7, 2024 14:28
@janosh janosh merged commit 8657780 into master Sep 7, 2024
44 checks passed
@janosh janosh deleted the fix-gh-4051 branch September 7, 2024 14:38
@JaGeo
Copy link
Member

JaGeo commented Sep 7, 2024

Thanks @janosh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
fix Bug fix PRs io Input/output functionality vasp Vienna Ab initio Simulation Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: INCAR Updates not working
2 participants
@janosh @JaGeo