-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ext.COD
from mysql
to REST API
#4117
Migrate ext.COD
from mysql
to REST API
#4117
Conversation
|
||
@pytest.mark.skipif(not which("mysql"), reason="No mysql") | ||
def test_get_structure_by_formula(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime for test_get_structure_by_formula
is pretty long at around 30 seconds:
... [100%]
====================================================== slowest 30 durations ======================================================
30.34s call tests/ext/test_cod.py::TestCOD::test_get_structure_by_formula
2.05s call tests/ext/test_cod.py::TestCOD::test_get_cod_ids
1.94s call tests/ext/test_cod.py::TestCOD::test_get_structure_by_id
(6 durations < 0.005s hidden. Use -vv to show these durations.)
3 passed in 37.00s
Reason being Li2O
returned 16 structures, and each take ~ 2s, maybe use FeH18C3(N3F2)3
instead which has only one match.
87305b8
to
d32f06c
Compare
eae9a4e
to
9dbf05e
Compare
9dbf05e
to
c18823c
Compare
Thanks. |
No problem, thanks for reviewing and for original bringing up the idea to migrate to REST API |
Summary
ext.COD
frommysql
to REST API, to close [Dev] Removemysql
dependency fromext.cod
and fix S608 #4016timeout
arg fromget_structure_by_id
method and use a single class leveltimeout