Migrate ext.COD from mysql to REST API
#4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
commented
Oct 17, 2024
|
|
||
| @pytest.mark.skipif(not which("mysql"), reason="No mysql") | ||
| def test_get_structure_by_formula(self): |
There was a problem hiding this comment.
The runtime for test_get_structure_by_formula is pretty long at around 30 seconds:
... [100%]
====================================================== slowest 30 durations ======================================================
30.34s call tests/ext/test_cod.py::TestCOD::test_get_structure_by_formula
2.05s call tests/ext/test_cod.py::TestCOD::test_get_cod_ids
1.94s call tests/ext/test_cod.py::TestCOD::test_get_structure_by_id
(6 durations < 0.005s hidden. Use -vv to show these durations.)
3 passed in 37.00s
Reason being Li2O returned 16 structures, and each take ~ 2s, maybe use FeH18C3(N3F2)3 instead which has only one match.
DanielYang59
force-pushed
the
migrate-ext-cod-to-rest
branch
from
87305b8
to
d32f06c
Compare
DanielYang59
force-pushed
the
migrate-ext-cod-to-rest
branch
2 times, most recently
from
eae9a4e
to
9dbf05e
Compare
DanielYang59
force-pushed
the
migrate-ext-cod-to-rest
branch
from
9dbf05e
to
c18823c
Compare
|
Thanks. |
|
No problem, thanks for reviewing and for original bringing up the idea to migrate to REST API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ext.CODfrommysqlto REST API, to close [Dev] Removemysqldependency fromext.codand fix S608 #4016timeoutarg fromget_structure_by_idmethod and use a single class leveltimeout