Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to choose distribution in xavier_init #174

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

lbluque
Copy link
Contributor

@lbluque lbluque commented Sep 26, 2023

Summary

  • choose distribution and gain

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (29709ec) 97.96% compared to head (b27d8ab) 97.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   97.96%   97.97%           
=======================================
  Files          28       28           
  Lines        1822     1828    +6     
=======================================
+ Hits         1785     1791    +6     
  Misses         37       37           
Files Coverage Δ
matgl/utils/training.py 91.51% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shyuep shyuep merged commit 9aa74a0 into materialsvirtuallab:main Sep 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants