Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Training a MEGNet Formation Energy Model with PyTorch Lightnin… #185

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

1152041831
Copy link
Contributor

…g.ipynb

Bug fix: Resolved parameter input issue in MEGNetDataset from v0.8.3 and higher versions Description:
This pull request addresses the problem of parsing input parameters when constructing MEGNetDataset in this scenario. The issue arose due to the refactoring of MEGNetDataset in v0.8.3 and higher versions. The modifications made here ensure compatibility with the syntax of the new version.

Summary

Major changes:

  • feature 1: ...
  • fix 1: ...

Todos

If this is work in progress, what else needs to be done?

  • feature 2: ...
  • fix 2:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

…g.ipynb

Bug fix: Resolved parameter input issue in MEGNetDataset from v0.8.3 and higher versions
Description:
This pull request addresses the problem of parsing input parameters when constructing MEGNetDataset in this scenario.  The issue arose due to the refactoring of MEGNetDataset in v0.8.3 and higher versions.  The modifications made here ensure compatibility with the syntax of the new version.

Signed-off-by: Ming <55485031+1152041831@users.noreply.github.com>
@shyuep shyuep merged commit 9036184 into materialsvirtuallab:main Oct 31, 2023
@shyuep
Copy link
Contributor

shyuep commented Oct 31, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants