Middleware fix for released jobs #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusjunges
approved these changes
Aug 5, 2022
mateusjunges
added a commit
that referenced
this pull request
Jan 30, 2024
* allow to dispatch jobs without related models * Fix styling * Fix dispatchWithoutTracking helper to work without a model * docblock * wip * Fix styling * Middleware check for released jobs and new status: STATUS_RETRYING (#36) * Fix styling * Update changelog * Update README.md * Revert "Update README.md" This reverts commit 53d0968. * fix docs link (#39) * Laravel 10.x Compatibility (#41) * Bump dependencies for Laravel 10 * Update GitHub Actions for Laravel 10 * Update run-tests.yml * Update composer.json --------- Co-authored-by: Mateus Junges <mateus@junges.dev> * Remove composer.lock * Drop support for L8 and PHP 7.4 * Add note about support php and laravel versions * Update changelog * Fix docs * Update gitignore * Use FQCN as TrackedJob name * Improve docblocks and return types * wip * Fix styling * Update changelog * Fix styling * Register helpers * Update database * Upgrade min php to 8.2 * Improvements to track job without model * Fix styling * Drop support for laravel 9 * wip * Fix styling * Fix docs * update min php version on docs * wip * Update docs --------- Co-authored-by: mateusjunges <mateusjunges@users.noreply.github.com> Co-authored-by: Dima <DimaVIII@users.noreply.github.com> Co-authored-by: Laravel Shift <shift@laravelshift.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding: #35
Fix for: Jobs which get released back into the queue are getting marked as finished instead of "retrying".
Retrying status makes more sense here as setting the jobs as "queued" will be confusing.
This will indicate that the job has been tried already.
The method
markAsQueuedwas still added to the model as there are scenarios where it's useful to have this method if creating custom/additional middleware for this package.started_atis not set to null to to display when the job was started last time.