Adapt to hornerE respecting exponents - math-comp's PR #923 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure the second patch works with the current hornerE, but I'm not sure it still flies with the proposed new one ; I'm going to check. |
|
Ok, now I think we have something! |
proux01
approved these changes
Sep 14, 2022
| @@ -416,7 +416,7 @@ move=> n_gt0; have [->|xN0] := eqVneq x 0. | |||
| rewrite [LHS](@all_roots_prod_XsubC _ _ ws). | |||
| - by rewrite (monicP _) ?monic_XnsubC// scale1r big_map big_enum. | |||
| - by rewrite size_XnsubC// size_map size_enum_ord. | |||
| - rewrite all_map; apply/allP => i _ /=; rewrite /root !hornerE hornerXn. | |||
| - rewrite all_map; apply/allP => i _ /=; rewrite /root !hornerE ?hornerXn. | |||
There was a problem hiding this comment.
Suggested change
| - rewrite all_map; apply/allP => i _ /=; rewrite /root !hornerE ?hornerXn. | |
| - rewrite all_map; apply/allP => i _ /=; rewrite /root !hornerE ?hornerXn. | |
| (* FIXME: remove ?hornerXn above once requiring MathComp >= 1.16.0 *) |
| @@ -433,7 +433,7 @@ Lemma dvdp_minpoly_Xn_subn E : | |||
| (x ^+ p)%R \in E -> minPoly E x %| ('X^p - (x ^+ p)%:P). | |||
| Proof using. | |||
| move=> xpE; have [->|p_gt0] := posnP p; first by rewrite !expr0 subrr dvdp0. | |||
| by rewrite minPoly_dvdp /root ?poly_XnsubC_over// !hornerE hornerXn subrr. | |||
| by rewrite minPoly_dvdp /root ?poly_XnsubC_over// !hornerE ?hornerXn subrr. | |||
There was a problem hiding this comment.
Suggested change
| by rewrite minPoly_dvdp /root ?poly_XnsubC_over// !hornerE ?hornerXn subrr. | |
| by rewrite minPoly_dvdp /root ?poly_XnsubC_over// !hornerE ?hornerXn subrr. | |
| (* FIXME: remove ?hornerXn above once requiring MathComp >= 1.16.0 *) |
| @@ -1505,7 +1505,7 @@ have Cchar := Cchar => p_neq0; split. | |||
| move=> /radicalP[]; case: i => // i in epw * => _ uik. | |||
| pose v := i.+1.-root (iota (u ^+ i.+1)). | |||
| have : ('X ^+ i.+1 - (v ^+ i.+1)%:P).[iota u] == 0. | |||
| by rewrite !hornerE hornerXn rootCK// rmorphX subrr. | |||
| by rewrite !hornerE ?hornerXn rootCK// rmorphX subrr. | |||
There was a problem hiding this comment.
Suggested change
| by rewrite !hornerE ?hornerXn rootCK// rmorphX subrr. | |
| by rewrite !hornerE ?hornerXn rootCK// rmorphX subrr. | |
| (* FIXME: remove ?hornerXn above once requiring MathComp >= 1.16.0 *) |
| @@ -432,7 +432,7 @@ have Xxn0 : ('X - y%:P) ^+ n != 0 by rewrite ?expf_neq0 ?polyXsubC_eq0. | |||
| apply/eqP; rewrite eqn_leq mup_leq ?mup_geq//. | |||
| have [->|Nxy] := eqVneq x y. | |||
| by rewrite /= dvdpp ?dvdp_Pexp2l ?size_XsubC ?ltnn. | |||
| by rewrite dvd1p dvdp_XsubCl /root horner_exp !hornerE expf_neq0// subr_eq0. | |||
| by rewrite dvd1p dvdp_XsubCl /root !hornerE ?horner_exp ?hornerE expf_neq0// subr_eq0. | |||
There was a problem hiding this comment.
Suggested change
| by rewrite dvd1p dvdp_XsubCl /root !hornerE ?horner_exp ?hornerE expf_neq0// subr_eq0. | |
| by rewrite dvd1p dvdp_XsubCl /root !hornerE ?horner_exp ?hornerE expf_neq0// subr_eq0. | |
| (* FIXME: remove ?horner_exp ?hornerE above once requiring MathComp >= 1.16.0 *) |
|
I followed the suggestion. |
|
@CohenCyril CI green, this is backward compatible, could you merge? (if you agree with the upstream PR math-comp/math-comp#923 of course) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-patch is making Abel compile with both the current hornerE and the proposed revision.