Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the static strings to const char* #16

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Change the static strings to const char* #16

merged 1 commit into from
Sep 26, 2018

Conversation

peternewman
Copy link
Contributor

Hopefully closes #15

Untested on hardware

@peternewman
Change the static strings to const char*
22cd830 
Hopefully closes mathertel#15 

Untested on hardware
@peternewman peternewman mentioned this pull request Sep 16, 2018
Open
mathertel
mathertel approved these changes Sep 26, 2018
View reviewed changes
Copy link
Owner

@mathertel mathertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right.

@mathertel mathertel merged commit e71c326 into mathertel:master Sep 26, 2018
@peternewman
Copy link
Contributor Author

From discussion in #15 unfortunately it doesn't seem to fix the issue, but does make things better at least.

@peternewman peternewman deleted the patch-3 branch July 13, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathertel mathertel mathertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify error
2 participants
@peternewman @mathertel