Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more OLA RDM test suite discovered issues #37

Merged
merged 7 commits into from
Jan 21, 2022

Conversation

peternewman
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential improvement

src/DMXSerial2.cpp Outdated Show resolved Hide resolved
src/DMXSerial2.cpp Outdated Show resolved Hide resolved
src/DMXSerial2.cpp Outdated Show resolved Hide resolved
@peternewman
Copy link
Contributor Author

If you want to review this @chrisstaite, I certainly wouldn't object, although I think these issues have already been fixed in TeensyDMX.

@mathertel mathertel merged commit 98cdfc9 into mathertel:master Jan 21, 2022
@mathertel
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants