Added support for sensors #7

StefanKrupop · 2017-05-25T18:32:33Z

This change allows defining sensors in the RDMINIT struct. When a defined sensor is queried via RDM, a callback function is called with the sensor number as input. The function can then set the current, minimum, maximum and recorded value.

- Added callback to retrieve sensor values

…PARAMETERS reply

peternewman

Some comments, mostly from the perspective of the E1.20 spec. Have you tried running the new code against the OLA RDM tests?

peternewman · 2017-05-27T23:32:55Z

src/DMXSerial2.cpp

          WRITEINT(_rdm.packet.Data   , E120_MANUFACTURER_LABEL);
          WRITEINT(_rdm.packet.Data+ 2, E120_DEVICE_MODEL_DESCRIPTION);
          WRITEINT(_rdm.packet.Data+ 4, E120_DEVICE_LABEL);
+          WRITEINT(_rdm.packet.Data+ 6, E120_SENSOR_DEFINITION);


There's not much point declaring these if the device doesn't have any sensors (i.e. sensorsLength <= 0).

peternewman · 2017-05-27T23:35:39Z

src/DMXSerial2.cpp

+          nackReason = E120_NR_SUB_DEVICE_OUT_OF_RANGE;
+        } else {
+          uint8_t sensorNr = _rdm.packet.Data[0];
+          if (sensorNr >= _initData->sensorsLength) {


Should also check that sensorNr < 0xff (all sensors) either here, or at init time.

Hm... sensorsLength is defined as uint8_t, so the highest possible value would be 0xff anyway. As the "if" here checks for larger or equal, it would return E120_NR_DATA_OUT_OF_RANGE when the user would have defined 255 sensors and sensorNr is 0xff.
Maybe it's too late here (3:38 am), but I think the logic works.

That's sort of my point, you can only have 254 sensors, but you could technically pass 255 into the system. It probably really wants to be at init time, but you ought to ignore a sensor 255, as that's reserved for "all sensors".

but you ought to ignore a sensor 255

Isn't this exactly what is happening? If the user should have passed 255 sensors, sensorsLength would also be 255. If then sensor 255 is requested, the library replies with E120_NR_DATA_OUT_OF_RANGE instead of the sensor data, effectively ignoring it.
Also, for any smaller number of defined sensors 255 will result in E120_NR_DATA_OUT_OF_RANGE.

Sorry, but I still do not see the case where this is problematic...

Yep fair point. I think it needs trapping/overwriting earlier though as otherwise devInfo->sensorCount will be populated by it, which can't be valid.

Actually, double-checking the standard, it says "Valid sensor numbers are in the range from 0x00 – 0xFE. The sensor number 0xFF is used to address all sensors." and "When a device or sub-device is fitted with a single sensor, it would return a value of 0x01 for the Sensor Count. This sensor would then be addressed as Sensor Number 0x00 when using the other sensor-related parameter messages.".

So you can have 255 sensors, which are addressed as 0 to 254.

peternewman · 2017-05-27T23:36:27Z

src/DMXSerial2.cpp

+          nackReason = E120_NR_SUB_DEVICE_OUT_OF_RANGE;
+        } else {
+          uint8_t sensorNr = _rdm.packet.Data[0];
+          if (sensorNr >= _initData->sensorsLength) {


Again 0xff.

peternewman · 2017-05-27T23:37:44Z

src/DMXSerial2.cpp

+          }
+        }
+      } else if (CmdClass == E120_SET_COMMAND) {
+        // Unexpected set


Not unexpected, SET lets you clear/reset the recorded info. Here 0xff (all) clears for all sensors.

peternewman · 2017-05-27T23:39:33Z

src/DMXSerial2.cpp

@@ -344,14 +345,15 @@ int random255();

 // Initialize or reinitialize the DMX RDM mode.
 // The other values are stored for later use with the specific commands.
-void DMXSerialClass2::init(struct RDMINIT *initData, RDMCallbackFunction func, uint8_t modePin, uint8_t modeIn, uint8_t modeOut)
+void DMXSerialClass2::init(struct RDMINIT *initData, RDMCallbackFunction func, RDMGetSensorValue sensorFunc, uint8_t modePin, uint8_t modeIn, uint8_t modeOut)


This will break people's existing code, you should probably either stick it at the end, or do a wrapper version of the old prototype which calls the new one with a NULL.

Ok, added init with "old" signature in header

- Only report E120_SENSOR_DEFINITION and E120_SENSOR_VALUE when sensors are defined - Fixed comment for settings sensor values

StefanKrupop · 2017-05-28T07:44:42Z

Yes, with some other (unrelated) fixes, I can get:
367 / 426 tests run, 367 passed, 0 failed, 0 broken
Tested with "OLA Responder Tests Version 0.10.3".

… are no sensors defined

mathertel · 2017-06-29T20:31:17Z

I just had the chance to check this pull request.
Thanks for the contribution.

peternewman · 2018-08-18T19:30:00Z

@saiteja9429 you'd be better off starting a new issue:
https://github.com/mathertel/DmxSerial2/issues/new

I suspect it's most likely to be an electrical/electronic issue. Does DMX work to the device?

ghost · 2018-08-18T22:04:28Z

I have discovered many small issues with DMXcat, not sure if it is in the phone app or in the DMXcat unit's software or hardware.

saiteja9429 · 2018-08-19T08:38:49Z

Hi, Thanks for the Mail. I have tried this by uploading in to my Arduino board and connected DMXCat but It is not discovering the device. Is there any particular pin to connect and check with or did I need to change anythinv in the code regarding UID I didn't find any pin configuration in the program. Thanks & Regards, Sai Teja

…

On Sun, Aug 19, 2018, 1:00 AM Peter Newman ***@***.***> wrote: @saiteja9429 <https://github.com/saiteja9429> you'd be better off starting a new issue: https://github.com/mathertel/DmxSerial2/issues/new I suspect it's most likely to be an electrical/electronic issue. Does DMX work to the device? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdSxJZ1ovplEwEVC3Z7Us3TAR56pCrQ_ks5uSGs5gaJpZM4NmumW> .

peternewman · 2018-08-19T14:04:03Z

Do you have access to a DMXcat @Jabadabado ?

@saiteja9429 there's a chance it could be this bug #10 . I've done an untested fix here #13

Have you wired up the direction pin of your RS485 transciever to the Arduino? By default it should be connected to pin 2, or you can override it by changing init() :
https://github.com/mathertel/DmxSerial2/blob/master/src/DMXSerial2.h#L178-L188

saiteja9429 · 2018-08-20T04:47:54Z

Hi Peter, I have tried what you have given but still DMXCat is not discovering in the mobile This is the connection i have given from MAX485 RE,DE - GND R0- Pin No. 2 (Arduino Uart Reception Pin) A,B,GND - DMXCat and also i have tried by connecting RE,DE to Vcc and R0 to Arduino transmission pin Could you please help me out in this. Thanks & Regards, CH Sai Teja

…

On Sun, Aug 19, 2018 at 7:34 PM, Peter Newman ***@***.***> wrote: Do you have access to a DMXcat @Jabadabado <https://github.com/jabadabado> ? @saiteja9429 <https://github.com/saiteja9429> there's a chance it could be this bug #10 <#10> . I've done an untested fix here #13 <#13> Have you wired up the direction pin of your RS485 transciever to the Arduino? By default it should be connected to pin 2, or you can override it by changing init() : https://github.com/mathertel/DmxSerial2/blob/master/src/ DMXSerial2.h#L178-L188 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdSxJZss6KHMt4KVtKDtVxeuEnu6owoQks5uSXBUgaJpZM4NmumW> .

saiteja9429 · 2018-08-20T04:56:10Z

DMXCat is connectiong but when i go to RDM Controller it is not disovering any device

…

On Sun, Aug 19, 2018 at 7:34 PM, Peter Newman ***@***.***> wrote: Do you have access to a DMXcat @Jabadabado <https://github.com/jabadabado> ? @saiteja9429 <https://github.com/saiteja9429> there's a chance it could be this bug #10 <#10> . I've done an untested fix here #13 <#13> Have you wired up the direction pin of your RS485 transciever to the Arduino? By default it should be connected to pin 2, or you can override it by changing init() : https://github.com/mathertel/DmxSerial2/blob/master/src/ DMXSerial2.h#L178-L188 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdSxJZss6KHMt4KVtKDtVxeuEnu6owoQks5uSXBUgaJpZM4NmumW> .

saiteja9429 · 2018-08-20T05:00:35Z

Can i use same manufacturer and RDM UID you have given in the code? On Mon, Aug 20, 2018 at 10:26 AM, Saiteja chinthalapati < saiteja9429@gmail.com> wrote:

…

DMXCat is connectiong but when i go to RDM Controller it is not disovering any device On Sun, Aug 19, 2018 at 7:34 PM, Peter Newman ***@***.***> wrote: > Do you have access to a DMXcat @Jabadabado > <https://github.com/jabadabado> ? > > @saiteja9429 <https://github.com/saiteja9429> there's a chance it could > be this bug #10 <#10> . > I've done an untested fix here #13 > <#13> > > Have you wired up the direction pin of your RS485 transciever to the > Arduino? By default it should be connected to pin 2, or you can override it > by changing init() : > https://github.com/mathertel/DmxSerial2/blob/master/src/DMXS > erial2.h#L178-L188 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#7 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AdSxJZss6KHMt4KVtKDtVxeuEnu6owoQks5uSXBUgaJpZM4NmumW> > . >

peternewman · 2018-08-20T10:33:22Z

That's your problem @saiteja9429 :

RE,DE - GND

Your system can't switch between Tx and Rx. You want the MAX485 connection parts of this or similar (I think you could get away without R1, I believe that's just to pull it up if the Arduino crashes):
https://www.instructables.com/id/Arduino-RDM-Relay/

In terms of the manufacturer and RDM UID, see the notes here:
https://github.com/mathertel/DmxSerial2/blob/master/src/DMXSerial2.cpp#L221-L236

That manufacturer ID is registered to Mathertel:
http://rdm.openlighting.org/manufacturer/display?manufacturer=2439

There are also a group reserved for prototyping:
http://rdm.openlighting.org/manufacturer/list

saiteja9429 · 2018-08-29T05:41:48Z

Hi, I have given the same connection in the above link and tried then devic is not discovering Please check below are the images when going in to RDM DMXCat LED is blinking contionuously but not able to discover the device

…

On Mon, Aug 20, 2018 at 4:03 PM Peter Newman ***@***.***> wrote: That's your problem @saiteja9429 <https://github.com/saiteja9429> : RE,DE - GND Your system can't switch between Tx and Rx. You want the MAX485 connection parts of this or similar (I think you could get away without R1, I believe that's just to pull it up if the Arduino crashes): https://www.instructables.com/id/Arduino-RDM-Relay/ In terms of the manufacturer and RDM UID, see the notes here: https://github.com/mathertel/DmxSerial2/blob/master/src/DMXSerial2.cpp#L221-L236 That manufacturer ID is registered to Mathertel: http://rdm.openlighting.org/manufacturer/display?manufacturer=2439 There are also a group reserved for prototyping: http://rdm.openlighting.org/manufacturer/list — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdSxJcpdiFC_5aGuYdpQkIclNPnCQGCrks5uSpB0gaJpZM4NmumW> .

StefanKrupop added 2 commits May 25, 2017 20:24

- Added description of sensors

8f989f5

- Added callback to retrieve sensor values

Added E120_SENSOR_DEFINITION and E120_SENSOR_VALUE to E120_SUPPORTED_…

a4880bb

…PARAMETERS reply

peternewman suggested changes May 27, 2017

View reviewed changes

StefanKrupop added 2 commits May 28, 2017 03:33

- Added init method with old signature

175db2a

- Only report E120_SENSOR_DEFINITION and E120_SENSOR_VALUE when sensors are defined - Fixed comment for settings sensor values

Fixed tab indentation

6a15c43

Do not handle E120_SENSOR_DEFINITION and E120_SENSOR_VALUE when there…

9d63952

… are no sensors defined

mathertel closed this Jun 29, 2017

mathertel reopened this Jun 29, 2017

mathertel merged commit 091abda into mathertel:master Jun 29, 2017

peternewman mentioned this pull request Aug 18, 2018

Example using sensors #11

Open

peternewman mentioned this pull request Aug 18, 2018

Proper response for DMX_START_ADDRESS (get+set) #3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for sensors #7

Added support for sensors #7

StefanKrupop commented May 25, 2017

peternewman left a comment

peternewman May 27, 2017

peternewman May 27, 2017

StefanKrupop May 28, 2017

peternewman Jun 24, 2017

StefanKrupop Jun 24, 2017

peternewman Jun 25, 2017

peternewman Jun 25, 2017

peternewman May 27, 2017

peternewman May 27, 2017

peternewman May 27, 2017

StefanKrupop May 28, 2017

StefanKrupop commented May 28, 2017

mathertel commented Jun 29, 2017

peternewman commented Aug 18, 2018

ghost commented Aug 18, 2018

saiteja9429 commented Aug 19, 2018 via email

peternewman commented Aug 19, 2018

saiteja9429 commented Aug 20, 2018 via email

saiteja9429 commented Aug 20, 2018 via email

saiteja9429 commented Aug 20, 2018 via email

peternewman commented Aug 20, 2018

saiteja9429 commented Aug 29, 2018 via email

Added support for sensors #7

Added support for sensors #7

Conversation

StefanKrupop commented May 25, 2017

peternewman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanKrupop commented May 28, 2017

mathertel commented Jun 29, 2017

peternewman commented Aug 18, 2018

ghost commented Aug 18, 2018

saiteja9429 commented Aug 19, 2018 via email

peternewman commented Aug 19, 2018

saiteja9429 commented Aug 20, 2018 via email

saiteja9429 commented Aug 20, 2018 via email

saiteja9429 commented Aug 20, 2018 via email

peternewman commented Aug 20, 2018

saiteja9429 commented Aug 29, 2018 via email