Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Add link for the usage of PRERELEASE_REPONAME. #8

Merged
merged 1 commit into from
Mar 26, 2017
Merged

[doc] Add link for the usage of PRERELEASE_REPONAME. #8

merged 1 commit into from
Mar 26, 2017

Conversation

130s
Copy link

@130s 130s commented Mar 26, 2017

mathias-luedtke
mathias-luedtke approved these changes Mar 26, 2017
View reviewed changes
Copy link
Owner

@mathias-luedtke mathias-luedtke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to link the comment or just add the example?

@130s 130s mentioned this pull request Mar 26, 2017
Merged
@130s
Copy link
Author

130s commented Mar 26, 2017

I thought link is fine -- for that usecase, which as you said might be rare, we might not want to use up too much text space. But I'll leave that up to you.

@mathias-luedtke mathias-luedtke merged commit dfe61cc into mathias-luedtke:enhancement/prerelease-updates Mar 26, 2017
@130s 130s deleted the enhancement/prerelease-updates branch March 26, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathias-luedtke mathias-luedtke mathias-luedtke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@130s @mathias-luedtke