-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mathics scanner release #1146
Conversation
4792f48
to
3aac712
Compare
Customize LineFeeder Routines for Mathics.
3aac712
to
c41566d
Compare
|
Would you please pull out the PossibleZeroQ and put that in its own PR. We'll merge that soon then
This PR addresses that. So that change can be reverted. Thanks. I am merging this in now. Feel free to keep commenting on it or improve it though. Merging in will allow mathicsscript and mathics-django to move closer to a release. |
See PR #1147
|
See comment on that PR. |
regarding send_messages in mathics-scanner, you did this to avoid introduce (implicit) references to mathics in mathics-scanner? |
Right - this was something that @GarkGarcia originally noticed. My goal for this weekend though is to get out a release of whatever it is we can. If I had to do again I probably would have totally left in with the Mathics dependencies (as you report doing) and fixed up in a later release. However since I went down this path, best not to go backwards, but instead go forward it in the places that use mathics scanner and not deal with backwards compatibilty of something that was never released. |
The PossibleZeroQ failure I think was a break from before and another branch may fix.
The RecursionLimit failure I'll investigate later.