Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign null value instead of using delete keyword #36

Closed
nijikokun opened this issue Dec 8, 2015 · 1 comment
Closed

Assign null value instead of using delete keyword #36

nijikokun opened this issue Dec 8, 2015 · 1 comment

Comments

@nijikokun
Copy link
Contributor

https://github.com/mathieuancelin/js-repaint-perfs/blob/gh-pages/ENV.js#L160

Setting null would give better performance than delete in this case, using delete seems like complete overkill.
@nijikokun nijikokun mentioned this issue Dec 8, 2015
Merged
mathieuancelin added a commit that referenced this issue Dec 9, 2015
@mathieuancelin
Merge pull request #37 from Nijikokun/fix/#36-delete-keyword
591eb79 
fix(env): Use null value over delete keyword
@mathieuancelin
Copy link
Owner

That's very nice :-)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nijikokun @mathieuancelin