Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update domvm #58

Merged
merged 2 commits into from
Apr 11, 2016
Merged

update domvm #58

merged 2 commits into from
Apr 11, 2016

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Apr 9, 2016

No description provided.

@mathieuancelin mathieuancelin merged commit c88eb60 into mathieuancelin:gh-pages Apr 11, 2016
@leeoniya
Copy link
Contributor Author

@mathieuancelin

thanks! i got another update on the way, actually. I didn't realize until now that mutations in this bench happen at the db level (rows) rather than cell level (tds). A simple optimization of oldDb === newDb yeilds 100% perf boost at 1% mutations, maybe 7% improvement at 50% and -5% regression at 100% (still investigating).

the resulting code is nearly identical by splitting off the row/db tpl into a sub-view and comparing the dbs (not at all esoteric). would this be considered an "optimized version" or should i just replace the main impl and maybe leave the old code in a large comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants