Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📱 Fix header menu & directory filter responsive #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marchalleo
Copy link
Contributor

  • Menu burger position (before/after) :
Capture d’écran 2024-02-22 à 15 45 52 Capture d’écran 2024-02-22 à 15 46 28
  • Directory filter category (before/after) :
Capture d’écran 2024-02-22 à 15 46 51 Capture d’écran 2024-02-22 à 15 47 15
  • Directory filter searchBar (before/after) :
Capture d’écran 2024-02-22 à 15 47 50 Capture d’écran 2024-02-22 à 15 48 03

Copy link

vercel bot commented Feb 22, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @mathieutu on Vercel.

@mathieutu first needs to authorize it.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 3:13pm

Copy link
Owner

@mathieutu mathieutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your help!

You changed a lot the style of the code, which make your changes more difficult to review. Could you revert them and focus only on your changes?

@marchalleo
Copy link
Contributor Author

Indeed, sorry!

I simplified with a new commit for better understanding.

Copy link
Owner

@mathieutu mathieutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you check the code diff. There are still a lot of unneeded changes, and the linter is failing. (your last commit didn't revert your changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants