Fix error with setting startup.elements in configuration. (mathjax/MathJax#2371) #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error that occurs when the
startupconfiguration block includes anelementsarray (intended to restrict the typesetting to a collection of containers). WIthout this patch, MathJax throws an error. (The problem was thatcombineConfig()tried to merge anullvalue into the array, thinking it was an object, sincetypeof null === 'object').It also turns out that the
elementsarray was never used, even if specifying it didn't cause an error, so this also fixes that problem.Finally, it simplifies the
findMathrender action, which was rather unpleasant to begin with.Resolves issue mathjax/MathJax#2371.