Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SVG honor the scale configuration option. (mathjax/MathJax#2376) #460

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 21, 2020

This PR fixes the problem where SVG output doesn't take the scale configuration option into account.

Resolves issue mathjax/MathJax#2376.

@working-name
Copy link

I can confirm SVG renderer honors scale configuration changes across the following browsers:

Safari 12.1 / 13.0.5
iOS 13.3.1 Safari (no idea what version that is)
Chrome 80.0.3987.132/149
Firefox 74.0
Epic 75.0.3770.100 (older chromium based)
Waterfox Current 2020.03
Firefox Quantum 60.6.1esr
Firefox Quantum 68.6.0esr
Edge 25.10586.0.0 (EdgeHTML 13.10586)
Internet Explorer 11.162.10586.0 (js patch made it spit a JS error 
but issue2376 branch compiled version works just fine)

@dpvc
Copy link
Member Author

dpvc commented Mar 23, 2020

@working-name, Great! Thanks for the thorough testing.

js patch made it spit a JS error but issue2376 branch compiled version works just fine

You probably need

        ready: function () {

rather than

        ready() {

in IE11.

Again, thanks for the support!

@working-name
Copy link

You are absolutely right. IE is now happy with the patch too, and honors scaling.

@dpvc
Copy link
Member Author

dpvc commented Mar 23, 2020

Thanks for the confirmation!

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit b8ba578 into develop Apr 3, 2020
@dpvc dpvc deleted the issue2376 branch April 3, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants