This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
run steamcmd as tty #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrisher
force-pushed
the
run-interactive
branch
from
8734e7c
to
2c50113
Compare
|
FYI here's the reason for the travis config changes: https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements |
|
Travis failed only on a single build with the errors expected from latency issues on |
|
Appveyor Node 5 failed with the node-gyp compile issue mentioned here: nodejs/node-gyp#972. Working on it. |
zrisher
force-pushed
the
run-interactive
branch
from
acd82ff
to
384f13f
Compare
|
Appveyor builds now fixed! |
|
Added retries per #15, hopefully all tests should pass the first time around now. |
|
@mathphreak Yay! All tests passing first try. Please let me know if you'd like any changes here. |
This was referenced Apr 13, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #13. Running as a TTY definitely fixes the stdout buffering issues we were facing, possibly makes steamCMD's behavior more predictable, and definitely gives us the flexibility to fine-tune our interaction with it down the line.
Not sure how well this will run on other platforms yet, so I'm submitting this PR to get the tests running.