chore: splitting and improving tests, enabling codecov failure #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maticardenas
force-pushed
the
small-refactor-tests
branch
from
7f2a582
to
eae1eee
Compare
…r-string-type Support numeric format for string type
maticardenas
force-pushed
the
small-refactor-tests
branch
3 times, most recently
from
8ef27d9
to
d847cc4
Compare
danut-t
reviewed
May 7, 2024
danut-t
approved these changes
May 7, 2024
maticardenas
force-pushed
the
small-refactor-tests
branch
from
d847cc4
to
db0c2d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing common function for preventing
dateserialization issues after they were spotted in fix: date not json serializable #35, and applying it in other parts where same serialization is performed. (@madhavsh96)Refactoring tests which are grouped withing classes, as identified in Support numeric format for string type #37, grouping them now per file and allowing the usage of
pytestfeatures such as parametrization (@danut-t)Enabling failure of
codecovstage, as with current plan and activity we have reached monthly limit (of250) and we are getting429responses now.