Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov and add integration tests coverage #1020

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Conversation

0xsharma
Copy link
Contributor

@0xsharma 0xsharma commented Oct 3, 2023

This PR adds codecov for integration tests. It also adds coverage for combined cover reports from unit-tests and integration-tests.

internal/cli/flagset/flagset.go Dismissed Show dismissed Hide dismissed
@0xsharma 0xsharma changed the base branch from master to develop October 3, 2023 10:30
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 1038 lines in your changes are missing coverage. Please review.

Files Coverage Δ
consensus/bor/bor.go 6.60% <ø> (-0.31%) ⬇️
consensus/bor/heimdall/metrics.go 12.50% <ø> (+3.40%) ⬆️
core/txpool/list.go 93.95% <100.00%> (+1.36%) ⬆️
core/types/block.go 29.30% <100.00%> (+6.95%) ⬆️
core/types/receipt.go 57.35% <ø> (+1.63%) ⬆️
eth/downloader/whitelist/checkpoint.go 100.00% <100.00%> (ø)
internal/cli/server/config.go 67.94% <100.00%> (-1.92%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
params/bootnodes.go 0.00% <ø> (ø)
params/config.go 31.63% <ø> (-0.02%) ⬇️
... and 53 more

... and 585 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@0xsharma 0xsharma changed the title Add GoCoverMerge support Fix Codecov and add integration tests coverage Oct 13, 2023
@0xsharma 0xsharma merged commit db1562b into develop Oct 13, 2023
16 of 17 checks passed
@0xsharma 0xsharma deleted the shivam/POS-1804 branch October 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants