Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : borTx chainID #1021

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix : borTx chainID #1021

merged 1 commit into from
Oct 4, 2023

Conversation

0xsharma
Copy link
Contributor

@0xsharma 0xsharma commented Oct 3, 2023

Description

In this PR, we fix the issue in which bor transaction was showing chainID 0x7fffffffffffffee. Bor transaction did not usually output a chainID but was recently introduced to do so with the upstream from go-ethereum ( below ).

// if a legacy transaction has an EIP-155 chain id, include it explicitly

if id := tx.ChainId(); id.Sign() != 0 {
	result.ChainID = (*hexutil.Big)(id)
}

@0xsharma 0xsharma requested review from ssandeep and a team October 3, 2023 14:22
@pratikspatil024 pratikspatil024 changed the base branch from master to v1.0.5-candidate October 4, 2023 06:26
@0xsharma 0xsharma merged commit d233e4f into v1.0.5-candidate Oct 4, 2023
14 checks passed
@0xsharma 0xsharma deleted the shivam/POS-1878 branch October 4, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants