Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth, consensus/bor: handle 503 status code in heimdall client #1023

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

manav2401
Copy link
Contributor

Description

When a new feature (like for the upcoming Aalborg hard fork) hasn't kicked in, the endpoints of heimdall will now return 503 (Service Unavailable) status code. This PR makes sure that bor handles that code separately and doesn't keep retying to fetch info.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

@manav2401 manav2401 requested a review from a team October 4, 2023 10:35
mh0lt pushed a commit to erigontech/erigon that referenced this pull request Oct 4, 2023
When a new feature (like for the upcoming `Aalborg` hard fork) for
Polygon hasn't kicked in (in heimdall), the endpoints of heimdall will
now return 503 (Service Unavailable) status code. This PR makes sure
that erigon handles that code separately and doesn't keep retying to
fetch info. It also acts as a notifier of the HF in erigon.

Similar reference PR in bor:
maticnetwork/bor#1023
@manav2401 manav2401 merged commit 766fdc3 into v1.0.5-candidate Oct 5, 2023
10 checks passed
@manav2401 manav2401 deleted the manav/handle-503-status-code branch October 5, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants