Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shanghai/Agra HF #1025

Merged
merged 23 commits into from
Oct 17, 2023
Merged

Shanghai/Agra HF #1025

merged 23 commits into from
Oct 17, 2023

Conversation

0xsharma
Copy link
Contributor

@0xsharma 0xsharma commented Oct 5, 2023

Description

Shanghai HF on Ethereum was done using timestamp rather than blockNumber. On POS, we would continue with blockNumber based hardforks.

In this PR, we convert the timestamp based HF to blockNumber based. Also, certain beacon chain related changes specefic to withdrawals( not applicable to Polygon-POS ) will also be removed.

@marcello33
Copy link
Contributor

Thanks @0xsharma
As discussed, once PR is ready, please make sure to delete the TODO marcello double check comments that I left there at time of upstream merge to make such changes related to the Shanghai HF.

@temaniarpit27 temaniarpit27 marked this pull request as ready for review October 9, 2023 07:33
@0xsharma 0xsharma changed the title Configure ShanghaiTIme to ShanghaiBlock Configure ShanghaiTime to ShanghaiBlock Oct 16, 2023
@temaniarpit27 temaniarpit27 changed the title Configure ShanghaiTime to ShanghaiBlock Shanghai HF Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1113 lines in your changes are missing coverage. Please review.

Files Coverage Δ
consensus/bor/heimdall/metrics.go 12.50% <ø> (+3.40%) ⬆️
core/state_transition.go 88.77% <ø> (-0.57%) ⬇️
core/txpool/list.go 93.95% <100.00%> (+1.36%) ⬆️
core/types/block.go 29.30% <100.00%> (+6.95%) ⬆️
core/types/receipt.go 57.35% <ø> (+1.63%) ⬆️
core/vm/evm.go 32.22% <100.00%> (+2.57%) ⬆️
core/vm/interpreter.go 29.08% <ø> (+2.67%) ⬆️
eth/catalyst/api.go 0.00% <ø> (-64.03%) ⬇️
eth/downloader/whitelist/checkpoint.go 100.00% <100.00%> (ø)
internal/cli/server/config.go 67.94% <100.00%> (-1.92%) ⬇️
... and 65 more

... and 573 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@temaniarpit27 temaniarpit27 changed the title Shanghai HF Shanghai/Agra HF Oct 17, 2023
chg : withdrawals check in bor consensus
@temaniarpit27 temaniarpit27 merged commit d104b38 into develop Oct 17, 2023
12 of 14 checks passed
@temaniarpit27 temaniarpit27 deleted the shivam/POS-1733 branch October 17, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants