-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shanghai/Agra HF #1025
Merged
Merged
Shanghai/Agra HF #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @0xsharma |
temaniarpit27
approved these changes
Oct 9, 2023
marcello33
approved these changes
Oct 9, 2023
0xsharma
changed the title
Configure ShanghaiTIme to ShanghaiBlock
Configure ShanghaiTime to ShanghaiBlock
Oct 16, 2023
add : agra HF mumbai block
Codecov ReportAttention:
... and 573 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
chg : withdrawals check in bor consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shanghai HF on Ethereum was done using timestamp rather than blockNumber. On POS, we would continue with blockNumber based hardforks.
In this PR, we convert the timestamp based HF to blockNumber based. Also, certain beacon chain related changes specefic to withdrawals( not applicable to Polygon-POS ) will also be removed.