Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: handle nil blocks and state when pending is not available #1053

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

manav2401
Copy link
Contributor

@manav2401 manav2401 commented Oct 19, 2023

Description

This PR includes a subset of changes from ethereum/go-ethereum#27218 which checks for nil header, state and receipt values when node is syncing and calls to pending are made.

Note that the rest of the changes in the PR will be pulled in routine upstream merge. Only the required fix is pulled.

This PR also handles nil state or error in the SendRawTransactionConditional api.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@manav2401 manav2401 merged commit 260deb8 into v1.1.0-beta-candidate Oct 20, 2023
8 checks passed
@manav2401 manav2401 deleted the manav/fix-nil-pending-header branch October 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants