Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bor: make withdrawal objects nil #1054

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

anshalshukla
Copy link
Contributor

Description

Makes withdrawals objects nil

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@anshalshukla anshalshukla changed the base branch from master to v1.1.0-beta-candidate October 20, 2023 09:46
consensus/bor/bor.go Outdated Show resolved Hide resolved
@marcello33
Copy link
Contributor

Please fix linter

@marcello33 marcello33 requested a review from a team October 20, 2023 09:52
core/state_processor.go Show resolved Hide resolved
params/config.go Outdated Show resolved Hide resolved
consensus/bor/bor.go Outdated Show resolved Hide resolved
@anshalshukla anshalshukla force-pushed the withdrawals branch 3 times, most recently from 11b2070 to 214b0a1 Compare October 20, 2023 14:28
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
core/genesis.go 45.69% <100.00%> (ø)
core/state_processor.go 92.19% <75.00%> (+0.16%) ⬆️
consensus/bor/bor.go 6.48% <0.00%> (-0.03%) ⬇️

... and 25 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@anshalshukla anshalshukla merged commit 95cee33 into v1.1.0-beta-candidate Oct 23, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants