params: fix bor key-value config look-up #1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 3 issues:
calculateBorConfigHelper
, previously used byCalculateBackupMultiplier
&CalculatePeriod
incorrectly returned the very last entry for block numbers that matched exactly a key in the map. Practically, it only affected Mumbai since BorMainnet has a single entry in theBackupMultiplier
&Period
maps.CalculateBurntContract
, used for the upcoming Agra fork, would've suffered from the same issue.borKeyValueConfigHelper
, can lead to bugs with blocks like 90M vs 100M (90,000,000 < 100,000,000, but lexicographically "90000000" > "100000000")Changes
Breaking changes
Mumbai-only:
CalculateBackupMultiplier(25275000)
&CalculatePeriod(25275000)
now correctly return 5 instead of 2.Testing