Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unprotected txns #1098

Merged
merged 4 commits into from
Dec 6, 2023
Merged

allow unprotected txns #1098

merged 4 commits into from
Dec 6, 2023

Conversation

temaniarpit27
Copy link
Contributor

Description

Hot fix for checks missing for allowing shadowfork and relay to work

core/txpool/validation.go Outdated Show resolved Hide resolved
temaniarpit27 and others added 3 commits December 3, 2023 17:14
Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com>
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (11969b0) 56.01% compared to head (073d75c) 55.95%.
Report is 1 commits behind head on develop.

Files Patch % Lines
core/types/transaction_signing.go 0.00% 15 Missing ⚠️
core/txpool/legacypool/legacypool.go 25.00% 4 Missing and 2 partials ⚠️
eth/backend.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1098      +/-   ##
===========================================
- Coverage    56.01%   55.95%   -0.07%     
===========================================
  Files          658      658              
  Lines       114446   114470      +24     
===========================================
- Hits         64111    64047      -64     
- Misses       46481    46576      +95     
+ Partials      3854     3847       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@temaniarpit27 temaniarpit27 merged commit abab36b into develop Dec 6, 2023
12 of 14 checks passed
@temaniarpit27 temaniarpit27 deleted the arpit/fix-shadowfork branch December 6, 2023 05:16
Woodpile37 added a commit to Woodpile37/bor that referenced this pull request Jan 10, 2024
commit dac4c40
Author: Vaibhav Jindal <vaibhavjindal29@gmail.com>
Date:   Mon Dec 18 15:38:12 2023 +0530

    Removed the check for milestoneID in the GetVoteOnHash()

commit 8b2f024
Author: Pratik Patil <pratikspatil024@gmail.com>
Date:   Fri Dec 15 12:49:11 2023 +0530

    test all default flags added via config file (maticnetwork#1105)

commit 2be2789
Merge: db5b398 18c8802
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Tue Dec 12 10:57:53 2023 +0530

    Merge pull request maticnetwork#1085 from bbaktaeho/fix/eth_api

    internal/ethapi: fix GetTransactionReceiptsByBlock method

commit db5b398
Author: marcello33 <marcelloardizzone@hotmail.it>
Date:   Fri Dec 8 06:56:23 2023 +0100

    Update matic-cli in CI (maticnetwork#1103)

commit abab36b
Merge: 1065e21 073d75c
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Wed Dec 6 10:46:55 2023 +0530

    Merge pull request maticnetwork#1098 from maticnetwork/arpit/fix-shadowfork

    allow unprotected txns

commit 073d75c
Merge: 4e3e1de 9682679
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:17:30 2023 +0530

    Merge branch 'arpit/fix-shadowfork' of github.com:maticnetwork/bor into arpit/fix-shadowfork

commit 4e3e1de
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:16:37 2023 +0530

    added log

commit 9682679
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Sun Dec 3 17:14:57 2023 +0530

    Update core/txpool/validation.go

    Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com>

commit 1065e21
Author: Anshal Shukla <53994948+anshalshukla@users.noreply.github.com>
Date:   Fri Dec 1 11:39:58 2023 +0530

    consensus/bor: handle blockalloc balance changes (maticnetwork#1074)

    * fix: set balance in blockalloc

    * chg: don't update balance if not zero

    * fix: lint

    * fix logic, add test cases

commit 91ff270
Author: Arpit Temani <temaniarpit27@gmail.com>
Date:   Thu Nov 30 15:35:46 2023 +0530

    allow unprotected txns

commit 18c8802
Author: bbaktaeho <bbaktaeho@gmail.com>
Date:   Fri Nov 17 19:34:50 2023 +0900

    fix: lint

commit 7714cd8
Author: bbaktaeho <bbaktaeho@gmail.com>
Date:   Thu Nov 16 23:04:53 2023 +0900

    fix GetTransactionReceiptsByBlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants