Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge "V1.3.0 beta candidate" into master #1202

Merged
merged 312 commits into from
Apr 12, 2024
Merged

Conversation

0xsharma
Copy link
Contributor

Description

In this PR, we merge "V1.3.0 beta candidate" into master and conclude the stable release for v1.3.0.

fjl and others added 30 commits August 25, 2023 15:59
* cmd, core, params: add support for the Holesky testnet

* cmd/devp2p: add support for holesky for the dns crawler
…#27976)

Just some minor optimizations I figured out a while ago. By using ReadBytes instead of
Bytes on the rlp stream, we can save the allocation of a temporary buffer for the typed tx
payload.

If kind == rlp.Byte, the size reported by Stream.Kind will be zero, but we need a buffer
of size 1 for ReadBytes. Since typed txs always have to be longer than 1 byte, we can just
return an error for kind == rlp.Byte.

There is a also a small change for Log: since the first three fields of Log are the ones that 
should appear in the canon encoding, we can simply ignore the remaining fields via 
struct tag. Doing this removes an indirection through the rlpLog type.

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
…e) (#27992)



Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
…#27872)

This PR makes EIP-4788 work in the engine API and miner. It also fixes some bugs related to 
EIP-4844 block processing and mining. Changes in detail:

- Header.BeaconRoot has been renamed to ParentBeaconRoot.
- The engine API now implements forkchoiceUpdatedV3
- newPayloadV3 method has been updated with the parentBeaconBlockRoot parameter
- beacon root is now applied to new blocks in miner
- For EIP-4844, block creation now updates the blobGasUsed field of the header
This changes implements faster post-selfdestruct iteration of storage slots for deletion, by using snapshot-storage+stacktrie to recover the trienodes to be deleted. This mechanism is only implemented for path-based schema. 

For hash-based schema, the entire post-selfdestruct storage iteration is skipped, with this change, since hash-based does not actually perform deletion anyway. 

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
This change defers to the blockchain for in what circumstances to return error, instead of handling many error-cases in the api backend.
This makes it possible to run the execution-spec-tests (a.k.a. pyspec) in CI.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
A while back, statetests started coming with sender baked in, which at least 
evmone makes use of. Let's make use of that too, and save some cycles.
…sb) (#24877)

This chang creates a GaugeInfo metrics type for registering informational (textual) metrics, e.g. geth version number. It also improves the testing for backend-exporters, and uses a shared subpackage in 'internal' to provide sample datasets and ordered registry. 

Implements #21783

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
This change improves function description and simplifies logic in statedb update and commit operations.
* eth/catalyst: set random

* Apply suggestions from code review

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
beacon/engine: add shouldOverrideBuilder to payload envelope
* core/forkid: skip genesis forks by time

* core/forkid: add comment about skipping non-zero fork times

* core/forkid: skip all time based forks in genesis using loop

* core/forkid: simplify logic for dropping time-based forks
On ACD 163, it was agreed to bump the target and max blob values from `2/4` to `3/6` for future devnets until we could decide on final mainnet number. This change contains said update, making master pass all the hive tests. The final decision for mainnet cancun is still to be made.
---------

Co-authored-by: Felix Lange <fjl@twurst.com>
This changes removes the warn-printout about not finding unclean shutdown markers, which always happens on fresh installs / wiped databases.
This updates minisign to the latest version. One new thing is that minisign (not go-minisign) has started to prehash the file, and in order to make geth pass the version-check, we need to sign the file in legacy-mode.
 Avoids the somewhat expensive stack.Caller invocation by checking if it is needed
This fixes the derived value BlobGasPrice on the receipt of EIP-4844 transactions, which was previously erroneously set to the price cap.
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 46.72698% with 1001 lines in your changes are missing coverage. Please review.

Project coverage is 51.44%. Comparing base (4395894) to head (fd4b9c2).

❗ Current head fd4b9c2 differs from pull request most recent head 840ca99. Consider uploading reports for the commit 840ca99 to get more accurate results

Files Patch % Lines
core/blockchain.go 71.03% 39 Missing and 14 partials ⚠️
eth/catalyst/simulated_beacon.go 0.00% 53 Missing ⚠️
core/txpool/blobpool/blobpool.go 23.80% 46 Missing and 2 partials ⚠️
core/rawdb/accessors_trie.go 0.00% 46 Missing ⚠️
core/types/gen_header_json.go 0.00% 45 Missing ⚠️
core/chain_makers.go 71.81% 30 Missing and 12 partials ⚠️
eth/catalyst/api.go 30.00% 41 Missing and 1 partial ⚠️
core/asm/compiler.go 47.43% 39 Missing and 2 partials ⚠️
core/state/statedb.go 58.58% 32 Missing and 9 partials ⚠️
core/rawdb/ancient_utils.go 0.00% 38 Missing ⚠️
... and 60 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
- Coverage   55.95%   51.44%   -4.52%     
==========================================
  Files         658      794     +136     
  Lines      114496   131304   +16808     
==========================================
+ Hits        64067    67549    +3482     
- Misses      46575    59576   +13001     
- Partials     3854     4179     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xsharma 0xsharma marked this pull request as ready for review April 12, 2024 06:27
@0xsharma 0xsharma changed the title [WIP] merge "V1.3.0 beta candidate" into master merge "V1.3.0 beta candidate" into master Apr 12, 2024
Copy link
Member

@pratikspatil024 pratikspatil024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version

@0xsharma 0xsharma merged commit 46f93b1 into master Apr 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.